1790276 - Convert browser/actors/EncryptedMedia* JSM modules to ESMs

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, task)

Description

[Mike Conley (:mconley) (:⚙️)]

The JSMs in browser/actors/EncryptedMedia* are:

• https://searchfox.org/mozilla-central/rev/fb95a6dc3db347664f89998ab5843da4167c5140/browser/actors/EncryptedMediaChild.jsm
• https://searchfox.org/mozilla-central/rev/fb95a6dc3db347664f89998ab5843da4167c5140/browser/actors/EncryptedMediaParent.jsm

ESMification guide: https://docs.google.com/document/d/1cpzIK-BdP7u6RJSar-Z955GV--2Rj8V4x2vl34m36Go/edit

Comment 1

[steven w]

Attachment: Bug 1790276 - Convert browser/actors/EncryptedMedia* JSM modules to ESMs. r?mconley,kpatenio,niklas,NeilDeakin,gijs.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2de7cd4077e4
Convert browser/actors/EncryptedMedia* JSM modules to ESMs. r=Gijs.

Comment 3

[Atila Butkovits]

Backed out as requested.

Backout link: https://hg.mozilla.org/integration/autoland/rev/9ceef8c3adb3683ab79e456e00455965619b3855

Comment 4

[:Gijs (he/him)]

I left feedback on the patch indicating what I think still needs to happen here. :-)

Comment 5

[Atila Butkovits]

We also found this: https://treeherder.mozilla.org/logviewer?job_id=390245716&repo=autoland&lineNumber=2635
And this: https://treeherder.mozilla.org/logviewer?job_id=390246149&repo=autoland&lineNumber=6732

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b2e0534eca6
Convert browser/actors/EncryptedMedia* JSM modules to ESMs. r=Gijs.

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d15b6719c22
Backed out changeset 3b2e0534eca6 for causing lint failure. CLOSED TREE

Comment 8

[Atila Butkovits]

Backed out for causing lint failure.

Backout link: https://hg.mozilla.org/integration/autoland/rev/8d15b6719c225ba8f7916c2103f9211fc56d75b6

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=3b2e0534eca6eaf4204f3b1e5197063d3313dfbb&selectedTaskRun=FIzU8jjfQ96B12GFUG9DHQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=391860362&repo=autoland&lineNumber=280

Comment 9

[steven w]

Hi, i did some editing and update the phabricator.
Will you help me to push it?
Hopefully, it doesn't backed out again.

Comment 10

[:Gijs (he/him)]

(In reply to steven w from comment #9)

Hi, i did some editing and update the phabricator.
Will you help me to push it?
Hopefully, it doesn't backed out again.

Looks like Katherine has picked this up (thank you Katherine!) and it's not quite ready to be relanded.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45ae068daba3
Convert browser/actors/EncryptedMedia* JSM modules to ESMs. r=kpatenio,Gijs,credential-management-reviewers.

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/45ae068daba3