Closed Bug 1790313 Opened 2 years ago Closed 2 years ago

Add localized string for SitePermsAddon permission popup

Categories

(Toolkit :: Add-ons Manager, task, P3)

Product:
Toolkit
Component:
Add-ons Manager
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(2 files)

Bug 1790313 - Tweak localized messages for SitePermsAddon install flow. r=rpl.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1790313 - Localize SitePermsAddonWrapper#name. r=rpl.
48 bytes, text/x-phabricator-request
Details | Review

webextSitePerms.headerWithUnsignedWithPerms doesn't really convey the risk associated with installing the synthetic addon, as the potential abuser is the website, not the addon (which contains no code).

For this reason, we should have a specific text for this permission, which might look like:

Add Site permission add-on? 
Malicious websites can steal your private information or compromise your computer. 
Only add it if you trust the website 
This add-on grants the following capabilities to <hostname>
Blocks: 1790620

I'm not sure I want to change this very much. The idea is to stick pretty tightly to the existing metaphor and language we use around extensions.

Here's the current language, for reference:

webextSitePerms.headerUnsignedWithPerms=Add %1$S? This extension is unverified. Malicious extensions can steal your private information or compromise your computer. Only add it if you trust the source. This extension grants the following capabilities to %2$S:

I'd be ok with changing "Malicious extensions can..." to "Malicious extensions can be used to...", which is a bit more accurate on a technical level but carries the same nuance.

Blocks: 1790621
No longer blocks: 1790620

This issue looks like its own separate followup, and so I'm moving this to be a blocker of the tracking meta and to not be blocking Bug 1790621.

Blocks: 1737161
No longer blocks: 1790621

Agree this doesn't need to block. I'm sort of on the fence about the wording tweak from comment 1 — it would be slightly more accurate, but also makes the sentence more grammatically-complicated (with downstream effects on localization) and divergent from the text for regular add-ons.

OK, I chatted with Martin and we agreed there's some room for improvement here. Here's what we came up with:

First message:

Allow $site to install an add-on?

This add-on gives the site extra privileges that could allow it to steal your data or attack your computer.

Only install this add-on if you trust $site.

Second message:

This add-on gives $site access to MIDI devices (with sysex support).

This access can be dangerous, and allows the site to act like software installed on your computer.

Only install this add-on if you trust $site.
Blocks: 1790621
Severity: -- → N/A
Priority: -- → P3
Assignee: nobody → nchevobbe
Attachment #9300484 - Attachment description: WIP: Bug 1790313 - Tweak localized messages for SitePermsAddon install flow. → Bug 1790313 - Tweak localized messages for SitePermsAddon install flow. r=rpl.

(In reply to Bobby Holley (:bholley) from comment #4)

OK, I chatted with Martin and we agreed there's some room for improvement here. Here's what we came up with:

First message:

Allow $site to install an add-on?

This add-on gives the site extra privileges that could allow it to steal your data or attack your computer.

Only install this add-on if you trust $site.

Should the first message be changed for all the webextensions, or just for SitePermissionsAddons ones?

Flags: needinfo?(bholley)

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #7)

(In reply to Bobby Holley (:bholley) from comment #4)
Should the first message be changed for all the webextensions, or just for SitePermissionsAddons ones?

Just for SitePermissionAddons.

Flags: needinfo?(bholley)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d95f36cb7d7
Localize SitePermsAddonWrapper#name. r=rpl,fluent-reviewers,flod.
https://hg.mozilla.org/integration/autoland/rev/6ddfdcdfe372
Tweak localized messages for SitePermsAddon install flow. r=rpl.

Backed out for causing xpcshell failures on test_sitePermsAddonProvider.js.

Push with failures

Failure log

Backout link

[task 2022-11-04T17:56:15.708Z] 17:56:15     INFO -  TEST-START | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_sitePermsAddonProvider.js
[task 2022-11-04T17:56:16.413Z] 17:56:16  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_sitePermsAddonProvider.js | xpcshell return code: 0
[task 2022-11-04T17:56:16.414Z] 17:56:16     INFO -  TEST-INFO took 705ms
[task 2022-11-04T17:56:16.414Z] 17:56:16     INFO -  >>>>>>>
[task 2022-11-04T17:56:16.415Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:2906
[task 2022-11-04T17:56:16.417Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, Main Thread] WARNING: Couldn't get the user appdata directory, crash dumps will go in an unusual location: file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:2964
[task 2022-11-04T17:56:16.417Z] 17:56:16     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2022-11-04T17:56:16.418Z] 17:56:16     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2022-11-04T17:56:16.418Z] 17:56:16     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2022-11-04T17:56:16.419Z] 17:56:16     INFO -  running event loop
[task 2022-11-04T17:56:16.419Z] 17:56:16     INFO -  xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_sitePermsAddonProvider.js | Starting test_sitepermsaddon_provider_disabled
[task 2022-11-04T17:56:16.419Z] 17:56:16     INFO -  (xpcshell/head.js) | test test_sitepermsaddon_provider_disabled pending (2)
[task 2022-11-04T17:56:16.421Z] 17:56:16     INFO -  "Getting initial pref value for "dom.sitepermsaddon-provider.enabled""
[task 2022-11-04T17:56:16.422Z] 17:56:16     INFO -  "Setting pref "dom.sitepermsaddon-provider.enabled": false"
[task 2022-11-04T17:56:16.422Z] 17:56:16     INFO -  PID 19112 | [Socket 19129, Main Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpHandler.cpp:362
[task 2022-11-04T17:56:16.422Z] 17:56:16     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2022-11-04T17:56:16.423Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576043	addons.manager	DEBUG	Application has been upgraded"
[task 2022-11-04T17:56:16.424Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576049	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/GMPProvider.sys.mjs"
[task 2022-11-04T17:56:16.424Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576053	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/SitePermsAddonProvider.sys.mjs"
[task 2022-11-04T17:56:16.425Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576053	addons.manager	DEBUG	Starting provider: XPIProvider"
[task 2022-11-04T17:56:16.426Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576054	addons.xpi	DEBUG	startup"
[task 2022-11-04T17:56:16.427Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576054	addons.xpi	DEBUG	List of built-in add-ons is missing or invalid.: [Exception... "Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIXPCComponents_Utils.readUTF8URI]"  nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: startup :: line 2479"  data: no] Stack trace: startup()@resource://gre/modules/addons/XPIProvider.jsm:2479
[task 2022-11-04T17:56:16.428Z] 17:56:16     INFO -  callProvider()@resource://gre/modules/AddonManager.jsm:244
[task 2022-11-04T17:56:16.428Z] 17:56:16     INFO -  _startProvider()@resource://gre/modules/AddonManager.jsm:552
[task 2022-11-04T17:56:16.429Z] 17:56:16     INFO -  startup()@resource://gre/modules/AddonManager.jsm:758
[task 2022-11-04T17:56:16.430Z] 17:56:16     INFO -  startup()@resource://gre/modules/AddonManager.jsm:3671
[task 2022-11-04T17:56:16.430Z] 17:56:16     INFO -  observe()@resource://gre/modules/addonManager.js:75
[task 2022-11-04T17:56:16.431Z] 17:56:16     INFO -  promiseStartupManager()@resource://testing-common/AddonTestUtils.jsm:786
[task 2022-11-04T17:56:16.432Z] 17:56:16     INFO -  test_sitepermsaddon_provider_disabled()@/builds/worker/workspace/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/test_sitePermsAddonProvider.js:100
[task 2022-11-04T17:56:16.433Z] 17:56:16     INFO -  _run_next_test/<()@/builds/worker/workspace/build/tests/xpcshell/head.js:1775
[task 2022-11-04T17:56:16.433Z] 17:56:16     INFO -  _run_next_test()@/builds/worker/workspace/build/tests/xpcshell/head.js:1775
[task 2022-11-04T17:56:16.434Z] 17:56:16     INFO -  run()@/builds/worker/workspace/build/tests/xpcshell/head.js:819
[task 2022-11-04T17:56:16.435Z] 17:56:16     INFO -  _do_main()@/builds/worker/workspace/build/tests/xpcshell/head.js:240
[task 2022-11-04T17:56:16.435Z] 17:56:16     INFO -  _execute_test()@/builds/worker/workspace/build/tests/xpcshell/head.js:597
[task 2022-11-04T17:56:16.436Z] 17:56:16     INFO -  -e:1"
[task 2022-11-04T17:56:16.437Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576059	addons.xpi	INFO	SystemAddonLocation directory is missing"
[task 2022-11-04T17:56:16.438Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576074	addons.xpi	INFO	Removing all system add-on upgrades."
[task 2022-11-04T17:56:16.439Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576075	addons.xpi	DEBUG	checkForChanges"
[task 2022-11-04T17:56:16.440Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576076	addons.xpi	DEBUG	Loaded add-on state: ${}"
[task 2022-11-04T17:56:16.441Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576078	addons.xpi	DEBUG	scanForChanges changed: false, state: {}"
[task 2022-11-04T17:56:16.442Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576079	addons.xpi	DEBUG	Empty XPI database, setting schema version preference to 35"
[task 2022-11-04T17:56:16.443Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576079	addons.xpi	DEBUG	No changes found"
[task 2022-11-04T17:56:16.444Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576087	addons.manager	DEBUG	Registering shutdown blocker for XPIProvider"
[task 2022-11-04T17:56:16.444Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576088	addons.manager	DEBUG	Provider finished startup: XPIProvider"
[task 2022-11-04T17:56:16.446Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576088	addons.manager	DEBUG	Completed startup sequence"
[task 2022-11-04T17:56:16.447Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, NS_ERROR_INVALID_ARG) failed with result 0x80520012 (NS_ERROR_FILE_NOT_FOUND): file /builds/worker/checkouts/gecko/intl/l10n/L10nRegistry.cpp:393
[task 2022-11-04T17:56:16.447Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, GMPThread] WARNING: Failed to delete GMP storage directory: file /builds/worker/checkouts/gecko/dom/media/gmp/GMPServiceParent.cpp:1754
[task 2022-11-04T17:56:16.448Z] 17:56:16     INFO -  TEST-PASS | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_sitePermsAddonProvider.js | test_sitepermsaddon_provider_disabled - [test_sitepermsaddon_provider_disabled : 106] Expect no SitePermsAddonProvider to be registered - true == true
[task 2022-11-04T17:56:16.449Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576114	addons.manager	DEBUG	Starting provider: GMPProvider"
[task 2022-11-04T17:56:16.450Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576116	addons.manager	DEBUG	Registering shutdown blocker for GMPProvider"
[task 2022-11-04T17:56:16.451Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576117	addons.manager	DEBUG	Provider finished startup: GMPProvider"
[task 2022-11-04T17:56:16.452Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576131	addons.xpi-utils	DEBUG	Starting async load of XPI database /tmp/xpc-profile-7hfs_i0u/extensions.json"
[task 2022-11-04T17:56:16.453Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576137	addons.xpi-utils	DEBUG	Rebuilding XPI database with no extensions"
[task 2022-11-04T17:56:16.453Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576143	addons.manager	DEBUG	before shutdown"
[task 2022-11-04T17:56:16.454Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576145	addons.manager	DEBUG	shutdown"
[task 2022-11-04T17:56:16.455Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576146	addons.manager	DEBUG	Calling shutdown blocker for XPIProvider"
[task 2022-11-04T17:56:16.456Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576146	addons.xpi	DEBUG	shutdown"
[task 2022-11-04T17:56:16.457Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576146	addons.xpi-utils	DEBUG	shutdown"
[task 2022-11-04T17:56:16.457Z] 17:56:16     INFO -  "Clearing pref "dom.sitepermsaddon-provider.enabled""
[task 2022-11-04T17:56:16.458Z] 17:56:16     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2022-11-04T17:56:16.459Z] 17:56:16     INFO -  (xpcshell/head.js) | test test_sitepermsaddon_provider_disabled finished (2)
[task 2022-11-04T17:56:16.460Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576147	addons.manager	DEBUG	Calling shutdown blocker for GMPProvider"
[task 2022-11-04T17:56:16.461Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576152	addons.manager	DEBUG	Async provider shutdown done"
[task 2022-11-04T17:56:16.462Z] 17:56:16     INFO -  xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_sitePermsAddonProvider.js | Starting test_sitepermsaddon_provider_enabled
[task 2022-11-04T17:56:16.462Z] 17:56:16     INFO -  (xpcshell/head.js) | test test_sitepermsaddon_provider_enabled pending (2)
[task 2022-11-04T17:56:16.463Z] 17:56:16     INFO -  "Getting initial pref value for "dom.sitepermsaddon-provider.enabled""
[task 2022-11-04T17:56:16.463Z] 17:56:16     INFO -  "Getting initial pref value for "dom.sitepermsaddon-provider.separatedBlocklistedDomains""
[task 2022-11-04T17:56:16.464Z] 17:56:16     INFO -  "Setting pref "dom.sitepermsaddon-provider.enabled": true"
[task 2022-11-04T17:56:16.464Z] 17:56:16     INFO -  "Setting pref "dom.sitepermsaddon-provider.separatedBlocklistedDomains": malicious.com"
[task 2022-11-04T17:56:16.465Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, Main Thread] WARNING: Ignoring duplicate observer.: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:2787
[task 2022-11-04T17:56:16.466Z] 17:56:16     INFO -  (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2022-11-04T17:56:16.466Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576165	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/GMPProvider.sys.mjs"
[task 2022-11-04T17:56:16.467Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576166	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/SitePermsAddonProvider.sys.mjs"
[task 2022-11-04T17:56:16.468Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576166	addons.manager	DEBUG	Starting provider: GMPProvider"
[task 2022-11-04T17:56:16.468Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576167	addons.manager	DEBUG	Registering shutdown blocker for GMPProvider"
[task 2022-11-04T17:56:16.469Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576168	addons.manager	DEBUG	Provider finished startup: GMPProvider"
[task 2022-11-04T17:56:16.470Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576168	addons.manager	DEBUG	Starting provider: XPIProvider"
[task 2022-11-04T17:56:16.470Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576168	addons.xpi	DEBUG	startup"
[task 2022-11-04T17:56:16.471Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576168	addons.xpi	DEBUG	List of built-in add-ons is missing or invalid.: [Exception... "Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIXPCComponents_Utils.readUTF8URI]"  nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: startup :: line 2479"  data: no] Stack trace: startup()@resource://gre/modules/addons/XPIProvider.jsm:2479
[task 2022-11-04T17:56:16.472Z] 17:56:16     INFO -  callProvider()@resource://gre/modules/AddonManager.jsm:244
[task 2022-11-04T17:56:16.472Z] 17:56:16     INFO -  _startProvider()@resource://gre/modules/AddonManager.jsm:552
[task 2022-11-04T17:56:16.473Z] 17:56:16     INFO -  startup()@resource://gre/modules/AddonManager.jsm:758
[task 2022-11-04T17:56:16.473Z] 17:56:16     INFO -  startup()@resource://gre/modules/AddonManager.jsm:3671
[task 2022-11-04T17:56:16.473Z] 17:56:16     INFO -  observe()@resource://gre/modules/addonManager.js:75
[task 2022-11-04T17:56:16.474Z] 17:56:16     INFO -  promiseStartupManager()@resource://testing-common/AddonTestUtils.jsm:786
[task 2022-11-04T17:56:16.474Z] 17:56:16     INFO -  test_sitepermsaddon_provider_enabled()@/builds/worker/workspace/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/test_sitePermsAddonProvider.js:123
[task 2022-11-04T17:56:16.474Z] 17:56:16     INFO -  _run_next_test/<()@/builds/worker/workspace/build/tests/xpcshell/head.js:1775
[task 2022-11-04T17:56:16.475Z] 17:56:16     INFO -  _run_next_test()@/builds/worker/workspace/build/tests/xpcshell/head.js:1775
[task 2022-11-04T17:56:16.475Z] 17:56:16     INFO -  run()@/builds/worker/workspace/build/tests/xpcshell/head.js:819
[task 2022-11-04T17:56:16.475Z] 17:56:16     INFO -  _do_main()@/builds/worker/workspace/build/tests/xpcshell/head.js:240
[task 2022-11-04T17:56:16.475Z] 17:56:16     INFO -  _execute_test()@/builds/worker/workspace/build/tests/xpcshell/head.js:597
[task 2022-11-04T17:56:16.476Z] 17:56:16     INFO -  -e:1"
[task 2022-11-04T17:56:16.476Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576170	addons.xpi	INFO	SystemAddonLocation directory is missing"
[task 2022-11-04T17:56:16.476Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576171	addons.xpi	DEBUG	checkForChanges"
[task 2022-11-04T17:56:16.477Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576172	addons.xpi	DEBUG	Loaded add-on state: {}"
[task 2022-11-04T17:56:16.478Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576174	addons.xpi	DEBUG	scanForChanges changed: false, state: {}"
[task 2022-11-04T17:56:16.478Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576174	addons.xpi	DEBUG	No changes found"
[task 2022-11-04T17:56:16.479Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576175	addons.manager	DEBUG	Registering shutdown blocker for XPIProvider"
[task 2022-11-04T17:56:16.479Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576176	addons.manager	DEBUG	Provider finished startup: XPIProvider"
[task 2022-11-04T17:56:16.480Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576176	addons.manager	DEBUG	Completed startup sequence"
[task 2022-11-04T17:56:16.481Z] 17:56:16     INFO -  TEST-PASS | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_sitePermsAddonProvider.js | test_sitepermsaddon_provider_enabled - [test_sitepermsaddon_provider_enabled : 129] Expect SitePermsAddonProvider to be registered - true == true
[task 2022-11-04T17:56:16.481Z] 17:56:16     INFO -  TEST-PASS | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_sitePermsAddonProvider.js | test_sitepermsaddon_provider_enabled - [test_sitepermsaddon_provider_enabled : 135] There's no addons - 0 == 0
[task 2022-11-04T17:56:16.482Z] 17:56:16     INFO -  "Add a gated permission"
[task 2022-11-04T17:56:16.482Z] 17:56:16     INFO -  TEST-PASS | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_sitePermsAddonProvider.js | test_sitepermsaddon_provider_enabled - [test_sitepermsaddon_provider_enabled : 144] A siteperm addon is now available - 1 == 1
[task 2022-11-04T17:56:16.483Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576186	addons.manager	DEBUG	Starting provider: SitePermsAddonProvider"
[task 2022-11-04T17:56:16.483Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576186	addons.manager	DEBUG	Registering shutdown blocker for SitePermsAddonProvider"
[task 2022-11-04T17:56:16.484Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576187	addons.manager	DEBUG	Provider finished startup: SitePermsAddonProvider"
[task 2022-11-04T17:56:16.484Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576199	addons.xpi-utils	DEBUG	Starting async load of XPI database /tmp/xpc-profile-7hfs_i0u/extensions.json"
[task 2022-11-04T17:56:16.486Z] 17:56:16     INFO -  TEST-PASS | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_sitePermsAddonProvider.js | test_sitepermsaddon_provider_enabled - [test_sitepermsaddon_provider_enabled : 146] getAddonByID returns the expected addon - {"isUninstalling":false,"siteOrigin":"https://example.com","principal":{},"id":"100680ad546ce6a577f42f52df33b4cfdca756859e664b8d7de329b150d09ce9@siteperms.mozilla.org"} == {"isUninstalling":false,"siteOrigin":"https://example.com","principal":{},"id":"100680ad546ce6a577f42f52df33b4cfdca756859e664b8d7de329b150d09ce9@siteperms.mozilla.org"}
[task 2022-11-04T17:56:16.486Z] 17:56:16     INFO -  TEST-PASS | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_sitePermsAddonProvider.js | test_sitepermsaddon_provider_enabled - [test_sitepermsaddon_provider_enabled : 152] addon has expected sitePermissions - ["test/gatedSitePerm"] deepEqual ["test/gatedSitePerm"]
[task 2022-11-04T17:56:16.487Z] 17:56:16     INFO -  TEST-PASS | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_sitePermsAddonProvider.js | test_sitepermsaddon_provider_enabled - [test_sitepermsaddon_provider_enabled : 157] addon has expected type - "sitepermission" == "sitepermission"
[task 2022-11-04T17:56:16.488Z] 17:56:16     INFO -  PID 19112 | [fluent] Couldn't find a message: addon-sitepermission-host
[task 2022-11-04T17:56:16.489Z] 17:56:16  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_sitePermsAddonProvider.js | test_sitepermsaddon_provider_enabled - [test_sitepermsaddon_provider_enabled : 162] addon has expected name - null == "Site Permissions for example.com"
[task 2022-11-04T17:56:16.490Z] 17:56:16     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/test_sitePermsAddonProvider.js:test_sitepermsaddon_provider_enabled:162
[task 2022-11-04T17:56:16.491Z] 17:56:16     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:240
[task 2022-11-04T17:56:16.491Z] 17:56:16     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:597
[task 2022-11-04T17:56:16.492Z] 17:56:16     INFO -  -e:null:1
[task 2022-11-04T17:56:16.493Z] 17:56:16     INFO -  exiting test
[task 2022-11-04T17:56:16.493Z] 17:56:16     INFO -  "Clearing pref "dom.sitepermsaddon-provider.enabled""
[task 2022-11-04T17:56:16.494Z] 17:56:16     INFO -  "Clearing pref "dom.sitepermsaddon-provider.separatedBlocklistedDomains""
[task 2022-11-04T17:56:16.495Z] 17:56:16     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2022-11-04T17:56:16.496Z] 17:56:16     INFO -  _abort_failed_test@/builds/worker/workspace/build/tests/xpcshell/head.js:875:20
[task 2022-11-04T17:56:16.496Z] 17:56:16     INFO -  do_report_result@/builds/worker/workspace/build/tests/xpcshell/head.js:976:5
[task 2022-11-04T17:56:16.497Z] 17:56:16     INFO -  Assert<@/builds/worker/workspace/build/tests/xpcshell/head.js:73:21
[task 2022-11-04T17:56:16.498Z] 17:56:16     INFO -  proto.report@resource://testing-common/Assert.jsm:228:10
[task 2022-11-04T17:56:16.498Z] 17:56:16     INFO -  equal@resource://testing-common/Assert.jsm:270:8
[task 2022-11-04T17:56:16.499Z] 17:56:16     INFO -  test_sitepermsaddon_provider_enabled@/builds/worker/workspace/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/test_sitePermsAddonProvider.js:162:12
[task 2022-11-04T17:56:16.500Z] 17:56:16     INFO -  _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:240:6
[task 2022-11-04T17:56:16.501Z] 17:56:16     INFO -  _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:597:5
[task 2022-11-04T17:56:16.502Z] 17:56:16     INFO -  @-e:1:1
[task 2022-11-04T17:56:16.502Z] 17:56:16     INFO -  exiting test
[task 2022-11-04T17:56:16.503Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576203	addons.xpi-utils	DEBUG	Rebuilding XPI database with no extensions"
[task 2022-11-04T17:56:16.504Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "[fluent] Couldn't find a message: addon-sitepermission-host" {file: "resource://gre/modules/addons/SitePermsAddonProvider.sys.mjs" line: 119}]"
[task 2022-11-04T17:56:16.505Z] 17:56:16     INFO -  "Force a GC"
[task 2022-11-04T17:56:16.506Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576265	addons.manager	DEBUG	before shutdown"
[task 2022-11-04T17:56:16.507Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576266	addons.manager	DEBUG	shutdown"
[task 2022-11-04T17:56:16.509Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576267	addons.manager	DEBUG	Calling shutdown blocker for GMPProvider"
[task 2022-11-04T17:56:16.510Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576268	addons.manager	DEBUG	Calling shutdown blocker for XPIProvider"
[task 2022-11-04T17:56:16.511Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576268	addons.xpi	DEBUG	shutdown"
[task 2022-11-04T17:56:16.513Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576274	addons.xpi-utils	DEBUG	shutdown"
[task 2022-11-04T17:56:16.514Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576275	addons.manager	DEBUG	Calling shutdown blocker for SitePermsAddonProvider"
[task 2022-11-04T17:56:16.516Z] 17:56:16     INFO -  "CONSOLE_MESSAGE: (info) 1667584576280	addons.manager	DEBUG	Async provider shutdown done"
[task 2022-11-04T17:56:16.517Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, IPDL Background] WARNING: quota manager shutdown step: '0.000003s: startCrashBrowserTimer', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:3297
[task 2022-11-04T17:56:16.518Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, IPDL Background] WARNING: quota manager shutdown step: '0.000072s: initiateShutdownWorkThreads', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:3297
[task 2022-11-04T17:56:16.519Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, IPDL Background] WARNING: idb: '0.000081s: starting', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:3297
[task 2022-11-04T17:56:16.519Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, IPDL Background] WARNING: cache: '0.000088s: starting', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:3297
[task 2022-11-04T17:56:16.520Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, IPDL Background] WARNING: sdb: '0.000094s: starting', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:3297
[task 2022-11-04T17:56:16.521Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, IPDL Background] WARNING: fs: '0.000100s: starting', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:3297
[task 2022-11-04T17:56:16.522Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, IPDL Background] WARNING: ls: '0.000105s: starting', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:3297
[task 2022-11-04T17:56:16.522Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, IPDL Background] WARNING: quota manager shutdown step: '0.000113s: startKillActorsTimer', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:3297
[task 2022-11-04T17:56:16.523Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, IPDL Background] WARNING: quota manager shutdown step: '0.000284s: stopKillActorsTimer', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:3297
[task 2022-11-04T17:56:16.524Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, IPDL Background] WARNING: quota manager shutdown step: '0.000296s: shutdownAndJoinWorkThreads', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:3297
[task 2022-11-04T17:56:16.524Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, IPDL Background] WARNING: idb: '0.000301s: completed', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:3297
[task 2022-11-04T17:56:16.525Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, IPDL Background] WARNING: cache: '0.000346s: completed', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:3297
[task 2022-11-04T17:56:16.526Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, IPDL Background] WARNING: sdb: '0.000356s: completed', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:3297
[task 2022-11-04T17:56:16.527Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, IPDL Background] WARNING: fs: '0.000362s: completed', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:3297
[task 2022-11-04T17:56:16.527Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, IPDL Background] WARNING: ls: '0.000367s: completed', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:3297
[task 2022-11-04T17:56:16.528Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, IPDL Background] WARNING: quota manager shutdown step: '0.000373s: shutdownAndJoinIOThread', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:3297
[task 2022-11-04T17:56:16.529Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, IPDL Background] WARNING: quota manager shutdown step: '0.000549s: invalidatePendingDirectoryLocks', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:3297
[task 2022-11-04T17:56:16.529Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, IPDL Background] WARNING: quota manager shutdown step: '0.000561s: stopCrashBrowserTimer', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:3297
[task 2022-11-04T17:56:16.530Z] 17:56:16     INFO -  PID 19112 | [Socket 19129, Main Thread] WARNING: IPC message 'PSocketProcess::Msg_FOGData' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:504
[task 2022-11-04T17:56:16.530Z] 17:56:16     INFO -  PID 19112 | [Socket 19129, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4628
[task 2022-11-04T17:56:16.531Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp:3387
[task 2022-11-04T17:56:16.532Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4628
[task 2022-11-04T17:56:16.532Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, Main Thread] WARNING: XPCOM object PerThreadData destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp:215
[task 2022-11-04T17:56:16.535Z] 17:56:16     INFO -  PID 19112 | [Parent 19112, Main Thread] WARNING: XPCOM object SourceList destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp:215
[task 2022-11-04T17:56:16.536Z] 17:56:16     INFO -  <<<<<<<
[task 2022-11-04T17:56:16.536Z] 17:56:16     INFO -  INFO | Result summary:
[task 2022-11-04T17:56:16.536Z] 17:56:16     INFO -  INFO | Passed: 242
[task 2022-11-04T17:56:16.537Z] 17:56:16  WARNING -  INFO | Failed: 1
[task 2022-11-04T17:56:16.537Z] 17:56:16  WARNING -  One or more unittests failed.
[task 2022-11-04T17:56:16.537Z] 17:56:16     INFO -  INFO | Todo: 0
[task 2022-11-04T17:56:16.538Z] 17:56:16     INFO -  INFO | Retried: 1
[task 2022-11-04T17:56:16.538Z] 17:56:16     INFO -  SUITE-END | took 317s
[task 2022-11-04T17:56:16.539Z] 17:56:16     INFO -  Node moz-http2 server shutting down ...
[task 2022-11-04T17:56:16.539Z] 17:56:16     INFO -  http3Server server shutting down ...
[task 2022-11-04T17:56:16.686Z] 17:56:16    ERROR - Return code: 1
[task 2022-11-04T17:56:16.687Z] 17:56:16     INFO - TinderboxPrint: xpcshell-xpcshell<br/>242/<em class="testfail">1</em>/0
[task 2022-11-04T17:56:16.688Z] 17:56:16  WARNING - # TBPL FAILURE #
[task 2022-11-04T17:56:16.688Z] 17:56:16  WARNING - setting return code to 2
Flags: needinfo?(nchevobbe)

I found the issue, I'll push the updated patch

Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a63a50afa870
Localize SitePermsAddonWrapper#name. r=rpl,fluent-reviewers,flod.
https://hg.mozilla.org/integration/autoland/rev/939611b786d7
Tweak localized messages for SitePermsAddon install flow. r=rpl.

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #11)

I found the issue, I'll push the updated patch

I took a quick look to the change applied to the last patch and I think the only reason why that fixed the failure is that with that change both the expected and actual values for the addon name from that xpcshell test are now null, because the new addonsBundle.formatValueSync call added to the xpcshell test is also returning null (and logging the same warning it was logging in the failure log linked in comment 10):

I confirmed that is the case by running the test locally:

 0:00.53 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "[fluent] Couldn't find a message: addon-sitepermission-host" {file: "resource://gre/modules/addons/SitePermsAddonProvider.sys.mjs" line: 119}]"
 0:00.53 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "[fluent] Couldn't find a message: addon-sitepermission-host" {file: "/home/rpl/mozlab/projects/mc-reviews-contributors/obj-build-artifacts/_tests/xpcshell/toolkit/mozapps/extensions/test/xpcshell/test_sitePermsAddonProvider.js" line: 166}]"

It is odd, but it seems something that may be worth some more investigation to see why that is happening, wdyt?

Flags: needinfo?(nchevobbe)

(In reply to Luca Greco [:rpl] [:luca] [:lgreco] from comment #13)

It is odd, but it seems something that may be worth some more investigation to see why that is happening, wdyt?

I've already discussed about this with Nicolas over slack:

  • the actual fix for the unexpected failure was avoiding to call await promiseShutdownManager(); in the previous test and then call await promiseStartupManager() in the test that was triggering the failure
  • the reason for the unexpected behavior is likely the fact that we basically use an hack to simulate he AOM restarts (which is basically unloading the jsm)
  • it is not the first time that that hack bite us with some unexpected behavior (I'm pretty sure I fixed an intermittent which was triggered but that not a long time ago)

and so that would explain why the unexpected null string returned by addonsBundle.formatValueSync (and that I didn't change the calls to promiseShutdownManager/promiseStartupManager when I tried that locally, and so I was getting those two warns and i would be expected).

I would still followup with a couple of more changes to that test:

  • move the call to promiseStartupManager to an add_setup callback (otherwise the two tests couldn't be executed on their own, e.g. when investigating a failure in one and adding .only() ad the end of the add_task calls).

  • add an explicit assertion that make us sure that await addonsBundle.formatValue("addon-sitepermission-host", { host: PRINCIPAL_COM.host }) resolved to a non empty string, so that we wouldn't miss if we would break that test again in the future by mistake (and both expected and actual values ended up to be both null and technically pass the assertion).

Flags: needinfo?(nchevobbe)

https://hg.mozilla.org/mozilla-central/rev/a63a50afa870
https://hg.mozilla.org/mozilla-central/rev/939611b786d7

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch

(In reply to Luca Greco [:rpl] [:luca] [:lgreco] from comment #14)

I would still followup with a couple of more changes to that test

I filed Bug 1799401

Blocks: 1799529
Blocks: 1799793
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: