1790321 - In a profile with sync configured from before featureTour was enabled, the `browser.firefoxView.featureTour` pref stays at its default value indefinitely

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect)

Description

[Daniel Holbert [:dholbert]]

This is related to bug 1790319, but I figured it'd be worth spinning off separately.

In my regular browsing profile (where I have Firefox Sync configured and have other devices syncing as well), I didn't get any particular tour-invitation when running a Nightly with the Firefox View feature-tour enabled. (I checked on two different machines; no tour on either machine in my regular profile, though I do get a tour in a fresh profile.)

I'm not sure if this lack-of-a-tour-for-existing-sync-users was intentional or not; but it seems to mean that the tour pref is just left at its default value indefinitely (since taking the tour is what changes the pref value).

And this persistent/stuck "tour not yet seen" pref-status impacts the layout of the page (perhaps unintentionally) as described in bug 1790319; and I suspect it might have other side effects as well?

Anyway, just filing this bug to be sure it's something that's known/understood. If we'd like for existing users with Sync configured to see the Firefox View tour and to get this pref eventually set to its TRUE-flavored value, we need to take some sort of action to make that happen, because it's not happening right now.

Comment 1

[Ray Fambro]

Venetia -- Wanted to ping you on this one as well to bring some clarity on the question around the Tour.

Comment 2

[Vtay]

Existing sync users should see Firefox View feature tour the first time. @mviar FYI

Comment 3

[Daniel Holbert [:dholbert]]

I verified that I can reproduce this ("lack of a tour") in a fresh profile, FWIW.

Starting with a fresh Firefox profile, using tofay

1. Visit about:preferences#sync and sign in to an existing Firefox account.
2. Restart Firefox
3. Visit your Firefox View page (for the first time in this profile).

ACTUAL RESULTS:
No tour.

EXPECTED RESULTS:
Should see a tour, per comment 2.

Comment 4

[Meg Viar [:mviar]]

Thanks, Daniel. Working on a patch for this now, looks like we just need some tweaks to the message configurations.

Comment 5

[Daniel Holbert [:dholbert]]

Thanks!

(In reply to Venetia from comment #2)

Existing sync users should see Firefox View feature tour the first time. @mviar FYI

Side note: is the intent for folks to get a tour on every device that they have Firefox Sync configured on? Or do we just want them to see a tour on one device and then not on any other devices?

If that is the intent (tour on all devices): good, that seems likely what will happen after this bug here is fixed.
If that's not the intent: then perhaps we need to ensure that the pref value itself gets sync'ed, or we need to take some other action to avoid repeating the tour everywhere.

Comment 6

[Meg Viar [:mviar]]

Attachment: Bug 1790321 - Ensure that the Firefox View feature tour is displayed when users already have tab sync enabled

Comment 7

[Meg Viar [:mviar]]

(In reply to Daniel Holbert [:dholbert] from comment #5)

If that's not the intent: then perhaps we need to ensure that the pref value itself gets sync'ed, or we need to take some other action to avoid repeating the tour everywhere.

Syncing across devices addressed in bug 1790669

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/883aa9e5438c
Ensure that the Firefox View feature tour is displayed when users already have tab sync enabled r=jprickett

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/883aa9e5438c

Comment 10

[Daniel Holbert [:dholbert]]

Hmm, this bug's commit is be included in today's Nightly, but I'm still not seeing any sort of tour when I view Firefox View (and I still have browser.firefox-view.feature-tour set to its default value {"message":"FIREFOX_VIEW_FEATURE_TOUR","screen":"FEATURE_CALLOUT_1","complete":false}).

So this bug still seems to be present for me, in the sense that this pref is still stuck at its default value I'm still not being offered a Firefox View tour.

Do we know why that might happen? Should I file a new bug as a clone of this bug vs. should I reopen this bug?

Comment 11

[Daniel Holbert [:dholbert]]

Aha, I restarted Firefox just-in-case (didn't think it would matter because I didn't have an update pending), and now I did get a tour on my first visit to Firefox View. :) So this does seem to be fixed after all, though there was just a delay (or a need for an additional restart) in order for the tour to get triggered.

Comment 12

[Alice Varro [avarro], Ecosystem QA]

I have verified this issue using the latest Firefox Beta 106.0b3 (Build ID: 20220922185808) on Windows 10x64, macOS 12.3.1 and LinuxMint 20.2 x64 using the steps provided in Comment 3 and I can confirm the following:

• The Firefox View feature Tour is successfully displayed after logging into an existing Firefox account.