1790336 - Tune balanced heap limits to give parity on benchmarks

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P2)

Description

[Jon Coppeard (:jonco)]

It's important that using balanced heap limits doesn't regress performance for users.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1790336 - Part 1: Limit heap growth to sensible limit r?sfink

This limits the heap growth when using balanced heap limits to a factor of 3.
This allows increasing the heap growth factor so the heap can grow rapidly when
where is a lot of allocation happening without affecting memory use too badly.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1790336 - Part 2: Increase balanced heap growth factor r?sfink

Increasing this parameter gives us parity on our benchmarks in the testing I've
done so far.

Depends on D157094

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93bf49a3911b
Part 1: Limit heap growth to sensible limit r=sfink
https://hg.mozilla.org/integration/autoland/rev/a0110fc4a82e
Part 2: Increase balanced heap growth factor r=sfink

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/93bf49a3911b
https://hg.mozilla.org/mozilla-central/rev/a0110fc4a82e