Support per-screen targeting in AboutWelcome / Multistage Spotlight
Categories
(Firefox :: Messaging System, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox112 | --- | verified |
People
(Reporter: barret, Assigned: jprickett)
References
(Blocks 2 open bugs)
Details
(Keywords: perf-alert)
Attachments
(2 files)
We currently support filtering out screens from AboutWelcome and Spotlight based on conditions, but these are presently all hardcoded in code (searchfox link). If we wanted to ship a screen conditionally on release that we do not have built-in conditional targeting for we could not do it.
Instead, we could re-use our targeting infrastructure from ASRouter and embed filtering in each screen of a message. That would allow us to to do more complicated message targeting with less notice -- new conditional screen logic would no longer have to ride the trains to release.
|
||
Updated•2 years ago
|
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
|
|
||
Comment 1•1 year ago
|
||
|
|
||
Updated•1 year ago
|
|
Assignee | |
Updated•1 year ago
|
|
|
Assignee | |
Comment 2•1 year ago
|
||
|
|
||
Updated•1 year ago
|
|
|
Assignee | |
Comment 3•1 year ago
|
||
@pdahiya Seems like this should potentially be applied to the screens in _showAboutWelcomeModal rather than in the respective message providers. Do we need this functionality in the providers as well?
|
||
Updated•1 year ago
|
|
|
||
Comment 4•1 year ago
•
|
||
(In reply to Jason Prickett from comment #3)
@pdahiya Seems like this should potentially be applied to the screens in
_showAboutWelcomeModalrather than in the respective message providers. Do we need this functionality in the providers as well?
That's correct , we should expose screen targeting capability as an API that can be called from respective message provider as needed. First implementation can introduce screen targeting capability only for about:welcome default flow.
Pushed by jprickett@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/87fbdb490584 Adding functionality for onboarding and about welcome messages to be filtered with targeting r=omc-reviewers,barret,pdahiya
|
|
Assignee | |
Comment 6•1 year ago
|
||
We added a targeting property to the MOBILE_DOWNLOAD screen in about welcome, which functionally changes how the screen is displayed, but doesn't change the circumstances in which it displays under. If the user is not signed in to a Firefox account or signed in to a Firefox account, but hasn't synced a mobile device, then they should continue to see the screen. Testing should be almost the same as in Bug 1774067, which is where the screen was initially implemented.
|
||
Comment 7•1 year ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 8•1 year ago
|
||
|
|
||
Updated•1 year ago
|
Pushed by jprickett@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f14393afa5c8 Fixed screen targeting for mobile download onboarding string r=pdahiya
|
||
Comment 10•1 year ago
|
||
Backed out for causing bc failures in browser/components/newtab/test/browser/browser_aboutwelcome_multistage_default.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/6af9179774a210ded054fee1db4b37d88c5145d2
|
|
Assignee | |
Comment 11•1 year ago
|
||
Failure was due to an edge case in tests that we fixed, and filed Bug 1820865 to further enhance tests against the edge case.
|
||
Comment 12•1 year ago
|
||
Pushed by jprickett@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cad7b8ca0851 Fixed screen targeting for mobile download onboarding string r=pdahiya
|
||
Comment 13•1 year ago
|
||
| bugherder | ||
|
||
Comment 14•1 year ago
|
||
(In reply to Pulsebot from comment #12)
Pushed by jprickett@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cad7b8ca0851
Fixed screen targeting for mobile download onboarding string r=pdahiya
== Change summary for alert #37645 (as of Mon, 13 Mar 2023 14:13:58 GMT) ==
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) | Performance Profiles |
|---|---|---|---|---|---|
| 14% | welcome fcp | windows10-64-shippable-qr | cold fission webrender | 102.29 -> 88.00 | Before/After |
| 13% | welcome fcp | windows10-64-shippable-qr | cold fission webrender | 103.27 -> 90.29 | Before/After |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=37645
|
|
||
Updated•1 year ago
|
|
||
Comment 15•1 year ago
|
||
I have verified this enhancement using the steps provided here and I can confirm the following:
- Not signed in to FXA: The "Mobile Cross-Promo" Onboarding screen is displayed.
- Signed in to FXA but no mobile device synced: The "Mobile Cross-Promo" Onboarding screen is displayed.
- Signed in to FXA with a mobile device synced: The "Mobile Cross-Promo" Onboarding screen is NOT displayed.
Verified using the latest Firefox Beta (112.0b4 Build ID - 20230319180129) installed on Windows 10 x64, macOS 12.6.1, and Ubuntu 22.04 x64.
Description
•