1790473 - Convert /remote/cdp JSM modules to ESM

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Once all the shared modules have been converted to ESM modules over on bug 1790468 all the files under remote/cdp can be converted as well.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1790473 - [cdp] Convert /remote/cdp JSM modules to ESM

Depends on D158297

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1790473 - [remote] Remove remote/.eslintrc.js

Depends on D158298

Comment 3

[Julian Descottes [:jdescottes]]

Mark, Arai,

Quick question about frame scripts, as we have one in this folder: https://searchfox.org/mozilla-central/source/remote/cdp/sessions/frame-script.js

Should they be migrated to ESMs? It seems to work (or rather it doesn't seem to break) if I just manually rename them to sys.mjs (and ignore the eslint warning related to the usage of this, but I don't know if they are actually loaded as ESMs or just as a regular js file.

Comment 4

[Mark Banner (:standard8)]

(In reply to Julian Descottes [:jdescottes] from comment #3)

Should they be migrated to ESMs? It seems to work (or rather it doesn't seem to break) if I just manually rename them to sys.mjs (and ignore the eslint warning related to the usage of this, but I don't know if they are actually loaded as ESMs or just as a regular js file.

I think Arai would be best to answer this. I do know that we don't yet support workers as ES modules, but I don't know how frame scripts work. The fact that this works for it currently suggests that it isn't being loaded as a module.

Comment 5

[Tooru Fujisawa [:arai]]

Frame script does not support ESM, and it's always regular script.

https://searchfox.org/mozilla-central/rev/f36f074acc09f2dab0e9ffaba34b5f6714dec81d/dom/base/nsFrameMessageManager.cpp#1201-1204,1308

already_AddRefed<JS::Stencil>
nsMessageManagerScriptExecutor::TryCacheLoadAndCompileScript(
    const nsAString& aURL, bool aRunInUniqueScope,
    JS::Handle<JSObject*> aMessageManager) {
...
    stencil = JS::CompileGlobalScriptToStencil(cx, options, srcBuf);

to my understanding, the file extension doesn't matter, but import / export syntax doesn't work there.

Comment 6

[Julian Descottes [:jdescottes]]

Great! Thanks for the quick feedback :)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/407ee0d19e23
[cdp] Convert /remote/cdp JSM modules to ESM r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/256e9641f5ae
[remote] Remove remote/.eslintrc.js r=webdriver-reviewers,whimboo

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/407ee0d19e23
https://hg.mozilla.org/mozilla-central/rev/256e9641f5ae