Closed Bug 1790483 Opened 2 years ago Closed 1 year ago

Add basic lit vendoring for use in new widgets

Categories

(Firefox :: General, task)

task

Tracking

()

RESOLVED FIXED
109 Branch
Tracking Status
firefox109 --- fixed

People

(Reporter: hjones, Assigned: mstriemer)

References

(Blocks 1 open bug)

Details

(Whiteboard: [recomp])

Attachments

(1 file, 2 obsolete files)

We want to experiment with using the lit library for building out some new reusable components for Firefox.

For now it might be sufficient to just include the minified lit source available as a single file at https://cdn.jsdelivr.net/gh/lit/dist@2/all/lit-all.min.js

We will need to patch some usage of innerHTML which will otherwise gets sanitized and break lit-html. Otherwise this should provide us with a quick way to get started with using lit in central.

Blocks: 1790632

This adds a new lit.all.dev.mjs file which is the development version of lit.
It is unminified so we can more easily see changes between updates. For official
builds, we use a version that is locally minified by esbuild. It's still the
development version though, so we'll still see the dev warning.

Depends on D159765

Depends on: 1798911
Attachment #9299343 - Attachment description: Bug 1790483 - Vendor lit for toolkit widgets r?hjones → Bug 1790483 - Vendor lit for use in builds r?hjones
Attachment #9301429 - Attachment description: Bug 1790483 - Minify lit after importing → WIP: Bug 1790483 - Minify lit after importing
Whiteboard: [fidefe-reusable-components-ms1]
Attachment #9301429 - Attachment is obsolete: true
Attachment #9299343 - Attachment description: Bug 1790483 - Vendor lit for use in builds r?hjones → Bug 1790483 - Vendor the lit library in toolkit/content/widgets r?hjones
Assignee: hjones → mstriemer
Blocks: 1802041
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4f8e2b95246
Vendor the lit library in toolkit/content/widgets r=hjones

Backed out for causing bc failures on browser_all_files_referenced.js.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 2, expected +0
Flags: needinfo?(mstriemer)
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/384c57c5f3bf
Vendor the lit library in toolkit/content/widgets r=hjones
Flags: needinfo?(mstriemer)
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
Attachment #9294905 - Attachment is obsolete: true
Whiteboard: [fidefe-reusable-components-ms1] → [recomp]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: