Closed Bug 1790517 Opened 4 years ago Closed 3 years ago

Exclude build directories as part of `./mach ide vscode`

Categories

(Developer Infrastructure :: Developer Environment Integration, enhancement)

x86_64
Windows 10
enhancement

Tracking

(firefox120 fixed)

RESOLVED FIXED
Tracking Status
firefox120 --- fixed

People

(Reporter: nrishel, Assigned: Logan)

References

(Blocks 1 open bug, )

Details

Attachments

(1 external file)

Original discussion here.

clangd indexing of build directories takes an exceedingly long time in vscode and the cache is often invalidated. This eats a surprising amount of CPU, and on my device this regularly took over an hour. The issue appears to be that vscode doesn't recognize .hgignore as it does .gitignore.

Excluding the build directories largely resolves this issue. To resolve this the build directories should be excluded via vscode's files.exclude setting while running ./mach ide vscode.

There is an unpublished extension that reads **/.hgignore and updates search.exclude and files.exclude. One may want to maintain this for cleaner solution as our .hgignore has a lot of entries.

I filed bug 1797137 to document a manual process for doing this since there doesn't seem to be major movement here.

Assignee: nobody → loganrosen
Status: NEW → ASSIGNED

andi, could you please help land the attached patch? I don't have level 3 access.

Flags: needinfo?(bpostelnicu)
Flags: needinfo?(bpostelnicu)
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/c980fd9ab54e Exclude build directories as part of `./mach ide vscode`. r=firefox-build-system-reviewers,ahochheiden
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: