Closed Bug 1790533 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 35873 - [anchor-position] Support anchors on OOF boxes

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
firefox107 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35873 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35873
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[anchor-position] Support anchors on OOF boxes

This patch supports anchors on OOF boxes inside of a block
fragmentation context.

To do this, this patch:
a. Enables per-containing block layout of OOFs if they have
anchors.
b. Find laid out OOFs with anchors and add them to anchor
queries of their containing block chain.

This patch doesn't support anchors on in-flow boxes inside of
OOF yet. This needs to look into all children of OOFs, or
propagate a flag while style recalc, but unfortunately there
are no spare bit flags in |LayoutObject| as of today. How to
do it without a flag, or how to add a flag, is deferred to
future patches.

Bug: 1309178
Change-Id: I649338bd85e7a87cba0eac7f8cce54bbd5939765

Reviewed-on: https://chromium-review.googlesource.com/3885596
WPT-Export-Revision: 1dc0b8fcb9b05d602d61db9f54db6a79f7a8f362

PR 35873 applied with additional changes from upstream: 9e04c1f62688fb667fe1b27297b77f9ffe29cc86
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 7 subtests

Status Summary

Firefox

OK : 1
PASS: 2
FAIL: 5

Chrome

OK : 1
PASS: 6
FAIL: 1

Safari

OK : 1
PASS: 2
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2d8c13cf1995 [wpt PR 35873] - [anchor-position] Support anchors on OOF boxes, a=testonly https://hg.mozilla.org/integration/autoland/rev/0754aae51141 [wpt PR 35873] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2d8c13cf1995
https://hg.mozilla.org/mozilla-central/rev/0754aae51141

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox107: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.