Closed Bug 1790602 Opened 5 months ago Closed 4 months ago

[wpt-sync] Sync PR 35875 - Revert "[Private Network Access] Support service worker script update"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox107 fixed)

RESOLVED FIXED
107 Branch
Tracking Status
firefox107 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35875 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35875
Details from upstream follow.

Mike West <mkwst@chromium.org> wrote:

Revert "[Private Network Access] Support service worker script update"

This reverts commit 4f617a2060db8828b6caa16cdd57be12d4ec3af8.

Reason for revert: Suspected to be responsible for crashes in 1.

Original change's description:

[Private Network Access] Support service worker script update

This CL passes a proper client security state based on the
ServiceWorkerRegisterJob's policy container polices to GetLoaderFactoryForUpdateCheck which eventually gets to 1 where we
would use it to create a loader factory just like we did for new script
fetches. It also initialises policy container policies for the
ServiceWorkerRegisterJob constructor used by updates.

Now the PNA check will block the public->private/local fetches in wpt
tests.

1 https://source.chromium.org/chromium/chromium/src/+/main:content/browser/service_worker/service_worker_context_wrapper.cc;l=1651;drc=13dced01cce80364299ad7663479ad65069db73d
[2] https://source.chromium.org/chromium/chromium/src/+/main:content/browser/service_worker/service_worker_register_job.h;l=64-65;drc=13dced01cce80364299ad7663479ad65069db73d?q=register_job.h&ss=chromium%2Fchromium%2Fsrc

Bug: 1239551
Change-Id: I1871153d83ae97e4aba46437e6708d748865052e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3865859
Auto-Submit: Jonathan Hao \<phao@chromium.org>
Commit-Queue: Camille Lamy \<clamy@chromium.org>
Reviewed-by: Camille Lamy \<clamy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1044019}

Bug: 1239551
Change-Id: I0e57be7151fa035c191f635c586fac44d7500cb0
Reviewed-on: https://chromium-review.googlesource.com/3890988
WPT-Export-Revision: e961380f71c26d9518ba557c02170841c5bc5d9e

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 5 subtests

Status Summary

Firefox

OK : 1
PASS: 1
FAIL: 4

Chrome

OK : 1
PASS: 1
FAIL: 4

Safari

OK : 1
PASS: 1
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b981deea7959
[wpt PR 35875] - Revert two PNA CLs that seem to be causing crashes., a=testonly
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.