1790623 - Extend the Triage Owners report to include an indication if the Triage Owner is a member of the default security group

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, enhancement)

Description

[:glob ✱]

Extend the Triage Owners report to include an indication if the Triage Owner is a member of the default security group.

As this isn't necessarily an issue it should be presented as informative (eg. yes/no) rather than as an warning that needs to be addressed.

The column should only be visible to Mozilla employees.

Comment 1

[David Lawrence [:dkl]]

Attachment: GitHub Pull Request

Comment 2

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/d5448c8cf7f9eab04b50706866c80509889f1e4d

Comment 3

[Daniel Veditz [:dveditz]]

Unfortunately, this change is not all that useful for the "Core" product. The default core-security group has a small membership, but we quickly triage those into more specific groups that many of the triage owners are members of. A quick-ish hack might be to special case products whose default group is core-security (exact match), assume the triage owner is a member if they are a member of any group with a substring match for "core-security" (or /.*core-security/ ).

Or just leave it... the indicator added to individual bug views in bug 1790624 may be more useful in practice. It will certainly be seen more often!

Comment 4

[David Lawrence [:dkl]]

(In reply to Daniel Veditz [:dveditz] from comment #3)

Unfortunately, this change is not all that useful for the "Core" product. The default core-security group has a small membership, but we quickly triage those into more specific groups that many of the triage owners are members of. A quick-ish hack might be to special case products whose default group is core-security (exact match), assume the triage owner is a member if they are a member of any group with a substring match for "core-security" (or /.*core-security/ ).

Or just leave it... the indicator added to individual bug views in bug 1790624 may be more useful in practice. It will certainly be seen more often!

Well obviously it is easiest to just leave it but I don't want to leave something in place that not useful and just creating extra code to maintain.

I will create a new bug that addresses that special case changes you mentioned.

• For any products that have core-security as the default security group:
  ** If the triage owner is a member or one or more .*core-security named groups, then show the owner as being a member of default security.
  ** If the triage owner is NOT a member of one or more matches, then display no that they are not a member.

Sound good?

Comment 5

[David Lawrence [:dkl]]

(In reply to David Lawrence [:dkl] from comment #4)

• For any products that have core-security as the default security group:
  • If the triage owner is a member or one or more .*core-security named groups, then show the owner as being a member of default security.
  • If the triage owner is NOT a member of one or more matches, then display no that they are not a member.

Created bug 1796692

Comment 6

[Daniel Veditz [:dveditz]]

[Does bug 1796692] Sound good?

Yes, very good. I had mused about whether that would work when I made comment 3, but I was afraid it was asking for too much work

Thank you!