1790632 - Create an example Lit based button component

Status: RESOLVED DUPLICATE of bug 1791816

(Toolkit :: UI Widgets, task)

Description

[Hanna Jones [:hjones]]

As specified in the reusable components proposal, one of the first components we want to tackle is a Lit based button. We have a complete design spec for this, and it should be relatively straightforward using mostly existing button styles.

Once the Lit vendoring is in place I'll make a first pass at writing a new button component. At the very least this will give us an opportunity to test aspects of the plan laid out in that proposal, and will give us something more concrete to discuss when we're thinking about how to move the reusable components project forward.

Comment 1

[Hanna Jones [:hjones]]

Attachment: WIP: Bug 1790632 - add lit based fx-button component

Depends on D157473

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Core & HTML' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Just a random question: has anyone done any performance profiling on this kinds of UI widgets?
I'm mostly worried that this doesn't end up using the prototype cache, and thus any page load (UI load) becomes slower.
But perhaps I'm missing something obvious.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Olli Pettay [:smaug][[e-mail]] from comment #3)

Just a random question: has anyone done any performance profiling on this kinds of UI widgets?
I'm mostly worried that this doesn't end up using the prototype cache, and thus any page load (UI load) becomes slower.
But perhaps I'm missing something obvious.

I've been advocating for using plain button elements with classes for different variants such as "primary", sort what we already do today. IMHO the current wip patch is an unnecessarily convoluted abstraction in search for a real purpose that would justify introducing a custom element here.

Comment 5

[Hanna Jones [:hjones]]

This is no longer relevant now that the work of creating a button component is happening on Bug 1791816