Closed Bug 1790635 Opened 2 years ago Closed 1 year ago

Only disabled quick actions shown in certain cases

Categories

(Firefox :: Address Bar, defect, P3)

defect

Tracking

()

VERIFIED FIXED
112 Branch
Tracking Status
firefox112 --- verified

People

(Reporter: mak, Assigned: daisuke)

References

Details

Attachments

(1 file)

Open a new tab and type "screen".

Actual:
Capture screenshot is the only disabled action shown, so moving down with the mouse just selects the question mark button, that doesn't seem particularly useful

Expected:
If all the available actions are disabled, don't show QA at all. Or don't even return disabled actions, since what's the point of showing something I can't use?

Assignee: nobody → daisuke
Status: NEW → ASSIGNED

So the previous behaviour was to hide buttons and not show them disabled. However on testing we found it extremely confusing that an command could be returned sometimes but not others, as per your STR the user opens a new tab, types "screen" to try and take a screenshot and the action is not shown? Did the user do something wrong, are quickactions broken or disabled?

When the action is shown it is still confusing, but the user at least knows nothing is broken. This is particularly relevent for the QuickActions searchmode where the list should be an exhaustive list of available actions, but still relevant for individual results.

I think this is confusing either way, just slightly less confusing to have the current behaviour of the disabled action shown. I think ideally we fix this by not disabling the screenshot on about:newtab, it seems like about:config may be reasonable to hide but about:newtab I have actually wanted to screengrab a few times now. I will try to get someone who can make a decision about that involved

The severity field is not set for this bug.
:adw, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(adw)
Severity: -- → S3
Flags: needinfo?(adw)
Priority: -- → P3
Depends on: 1814630
Blocks: 1814630
No longer depends on: 1814630
Duplicate of this bug: 1814630
Attachment #9294568 - Attachment description: Bug 1790635: Hide QuickActions row if all actions are inactive. → Bug 1790635: Hide QuickActions row if all actions are inactive
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/45af0e8ffd75
Hide QuickActions row if all actions are inactive r=daleharvey
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch

Verified as fixed on 112 (flipped prefs) across platforms.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: