1790651 - Firefox View Feature Callout close button leaves focus in random places

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Dan Mosedale (:dmosedale, :dmose)]

+++ This bug was initially created as a clone of Bug #1790382; splitting outt the close button work so it can be parallelized +++

Per :ayeddi

• "When Close button is activated, the programmatic focus lands inconsistently somewhere on the page to any item that was under the Close button. It is expected that the focus would return to the top of the page, if the user did not navigate the page prior to getting on the onboarding popup. But if the user wandered around, the best place to return the focus would be the last focusable element before the onboarding popup was injected in the DOM or on the topmost element right after it, i.e. when the last popup is dismissed, the focus could be placed on the aside section for Colorways, for instance with the tabindex="-1" on the Independent Voices heading, so the user does not miss any piece of the content after the dismissal"

See featureCallout.mjs for feature callout code.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1790651 - place focus better on feature callout close, r?ayeddi,mviar

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1790651 - place focus better on feature callout close, r?emcminn

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db79ab8d3676
place focus better on feature callout close, r=ayeddi,emcminn

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/db79ab8d3676

Comment 5

[Alice Varro [avarro], Ecosystem QA]

I have verified this issue using the latest Firefox Beta 106.0b3 (Build ID: 20220922185808) on Windows 10x64, macOs12.3.1 and LinuxMint 20.2 x64.

• The focus after the user exits the callout tour is placed on most recently focused element.