1790677 - Implement functionality for creating and closing WebTransport session

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P3)

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1790677: Initial WebTransport IPC for creating and closing WebTransport r=#webidl,asuth,#ipc-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ed607207dc2
Initial WebTransport IPC for creating and closing WebTransport r=webidl,ipc-reviewers,smaug,nika

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37582 for changes under testing/web-platform/tests

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for causing bustage on /WebTransport.cpp

• backout: https://hg.mozilla.org/integration/autoland/rev/c3f6e44818e15f2a35a0abbf9674c15952358d95
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=P5fz58YISVOmM7WqS3pvMA.0&revision=8ed607207dc2507bedfcc2ff72c711fec98a47ca
• failure log: https://treeherder.mozilla.org/logviewer?job_id=400147645&repo=autoland&lineNumber=15408

[task 2022-12-19T20:12:59.669Z] 20:12:59     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/MozPromise.h:13:0,
[task 2022-12-19T20:12:59.669Z] 20:12:59     INFO -                   from /builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders/mozilla/dom/PWebTransport.h:15,
[task 2022-12-19T20:12:59.669Z] 20:12:59     INFO -                   from /builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders/mozilla/dom/PWebTransportChild.h:9,
[task 2022-12-19T20:12:59.670Z] 20:12:59     INFO -                   from /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebTransportChild.h:10,
[task 2022-12-19T20:12:59.670Z] 20:12:59     INFO -                   from /builds/worker/checkouts/gecko/dom/webtransport/api/WebTransport.h:14,
[task 2022-12-19T20:12:59.670Z] 20:12:59     INFO -                   from /builds/worker/checkouts/gecko/dom/webtransport/api/WebTransport.cpp:7,
[task 2022-12-19T20:12:59.670Z] 20:12:59     INFO -                   from Unified_cpp_dom_webtransport_api0.cpp:2:
[task 2022-12-19T20:12:59.671Z] 20:12:59     INFO -  /builds/worker/checkouts/gecko/dom/webtransport/api/WebTransport.cpp: In member function 'void mozilla::dom::WebTransport::RejectWaitingConnection(nsresult)':
[task 2022-12-19T20:12:59.672Z] 20:12:59    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/Logging.h:290:61: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'nsresult' [-Werror=format=]
[task 2022-12-19T20:12:59.672Z] 20:12:59     INFO -                                      MOZ_LOG_EXPAND_ARGS _args); \
[task 2022-12-19T20:12:59.673Z] 20:12:59     INFO -                                                               ^
[task 2022-12-19T20:12:59.674Z] 20:12:59     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/WebTransportLog.h:17:3: note: in expansion of macro 'MOZ_LOG'
[task 2022-12-19T20:12:59.675Z] 20:12:59     INFO -     MOZ_LOG(mozilla::gWebTransportLog, mozilla::LogLevel::Debug, args)
[task 2022-12-19T20:12:59.675Z] 20:12:59     INFO -     ^~~~~~~
[task 2022-12-19T20:12:59.675Z] 20:12:59     INFO -  /builds/worker/checkouts/gecko/dom/webtransport/api/WebTransport.cpp:151:3: note: in expansion of macro 'LOG'
[task 2022-12-19T20:12:59.675Z] 20:12:59     INFO -     LOG(("Rejected connection %x", aRv));
[task 2022-12-19T20:12:59.675Z] 20:12:59     INFO -     ^
[task 2022-12-19T20:12:59.675Z] 20:12:59     INFO -  cc1plus: all warnings being treated as errors
[task 2022-12-19T20:12:59.675Z] 20:12:59    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:669: Unified_cpp_dom_webtransport_api0.o] Error 1
[task 2022-12-19T20:12:59.675Z] 20:12:59     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/webtransport/api'
[task 2022-12-19T20:12:59.675Z] 20:12:59     INFO -  gmake[4]: Target 'target-objects' not remade because of errors.
[task 2022-12-19T20:12:59.675Z] 20:12:59    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: dom/webtransport/api/target-objects] Error 2

Comment 5

[Natalia Csoregi [:nataliaCs]]

Also failing on: dom/webtransport/test/xpcshell/test_close.js | setup - [setup : 42] "" != ""

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42d0f5fd1ebb
Initial WebTransport IPC for creating and closing WebTransport r=webidl,ipc-reviewers,smaug,nika

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/42d0f5fd1ebb

Comment 9

[Andra Esanu (needinfo me)]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ed607207dc2
Initial WebTransport IPC for creating and closing WebTransport
r=webidl,ipc-reviewers,smaug,nika

== Change summary for alert #36506 (as of Wed, 21 Dec 2022 09:54:51 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
10%	office loadtime	linux1804-64-shippable-qr	cold fission webrender	694.72 -> 627.77	Before/After

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=36506

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham