1790681 - Enable seperatePrivateDefault by default

Status: VERIFIED FIXED

(Firefox :: Search, task)

Description

[Dale Harvey (:daleharvey)]

This will not enable the feature for users but means the feature checkbox is enabled by default when the feature as a whole is enabled

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 1790681 - Enable separatePrivateDefault by default. r=Standard8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d463bad5348
Enable separatePrivateDefault by default. r=Standard8

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7d463bad5348

Comment 4

[Cristian Baica [:cbaica], Release Desktop QA]

Issue is verified fixed in latest nightly. The pref is correctly set to true in a new profile, without having 'browser.search.separatePrivateDefault.ui.enabled' set to true.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 9294613 [details]
Bug 1790681 - Enable separatePrivateDefault by default. r=Standard8

Beta/Release Uplift Approval Request

• User impact if declined: Changes default value for more appropriate setting when turning on the separate private ui.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Pref flip for code that's been around quite a while.
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9294613 [details]
Bug 1790681 - Enable separatePrivateDefault by default. r=Standard8

Approved for 105.0.2.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/f77386c3333a

Comment 8

[Adrian Florinescu [:aflorinescu]]

Verified as fixed with 105.0.2 on Ubuntu 22.04, Mac 11 and Windows 10.