Open
Bug 1790688
Opened 3 years ago
Updated 3 years ago
Move cookie banner handling mode logic from CookieBannerParent to nsCookieBannerService
Categories
(Core :: Privacy: Anti-Tracking, task, P3)
Core
Privacy: Anti-Tracking
Tracking
()
NEW
People
(Reporter: emz, Unassigned)
References
(Blocks 1 open bug)
Details
CookieBannerParent currently looks at the mode and returns the opt-in or opt-out click rule based on the pref. For cookie injection we do this directly in nsCookieBannerService. This is a bit confusing and leads to duplicate code. I propose that we move all mode handling logic to nsCookieBannerService and make the mode completely transparent for consumers.
|
||
Comment 1•3 years ago
|
||
+1 to this. I am essentially duplicating this logic inside browser/base/content/browser-siteProtections.js, in the cookieBannerHandling#hasException method. Would be great to centralize this logic in one place, especially since it can be challenging to figure out which C++ errors we need to catch on the front-end.
You need to log in
before you can comment on or make changes to this bug.
Description
•