Closed Bug 1790753 Opened 2 years ago Closed 2 years ago

DevToolsSocketStatus does not track browser toolbox connections

Categories

(DevTools :: General, defect, P3)

defect

Tracking

(firefox106 fixed)

RESOLVED FIXED
106 Branch
Tracking Status
firefox106 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

DevToolsSocketStatus is supposed to keep track of all the open socket for devtools. This is currently only used by https://searchfox.org/mozilla-central/source/browser/base/content/browser.js#8382 to decide to display or not the browser automation cue (stripes in the URL bar + robot icon).

However we explicitly avoid tracking Browser Toolbox sockets here, because we didn't want the Browser Toolbox to trigger the automation styling in the original Firefox instance.

This works fine for the browser.js use case, but it makes the DevToolsSocketStatus misleading, if someone else wants to start using it to really track all devtools sockets.

So DevToolsSocketStatus should probably track all opened sockets, but acknowledge the difference between BrowserToolbox and non-BrowserToolbox sockets.

The DevToolsSocketStatus could be misleading for any usage other than the current one from browser.js since it misses browser toolbox sockets

This patch allows the singleton to track all sockets but changes the API to allow consumers to exclude browser toolbox sockets.

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b84aa87b157
[devtools] Track all devtools sockets in DevToolsSocketStatus r=ochameau,Gijs
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: