Closed Bug 1790790 Opened 3 months ago Closed 2 months ago

Add Nimbus integration for separatePrivateSearch.ui

Categories

(Firefox :: Search, task, P1)

task

Tracking

()

VERIFIED FIXED
107 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox105 --- verified
firefox106 --- verified
firefox107 --- verified

People

(Reporter: daleharvey, Assigned: daleharvey)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → dharvey
Attachment #9294729 - Attachment description: WIP: Bug 1790790 - Add Nimbus integrations to control separate private default feature. r=Standard8 → Bug 1790790 - Add Nimbus integrations to control separate private default feature. r=Standard8
Attachment #9295200 - Attachment description: WIP: Bug 1790790 - Add Nimbus flag to control Search Private Default → Bug 1790790 - Add Nimbus flag to control Search Private Default. r=Standard8
Severity: -- → N/A
Priority: -- → P1
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3302226f71f
Add Nimbus flag to control Search Private Default. r=Standard8
Attachment #9294729 - Attachment is obsolete: true

Ah those tests landed after my patch was based so my try push was green, seen the problem and pushed a fix @ https://phabricator.services.mozilla.com/D157605, checking aother try run now

Flags: needinfo?(dharvey)
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6031e0a3a0b
Add Nimbus flag to control Search Private Default. r=Standard8

Sorry those tests didnt get run from mach try auto

Refactored the code to avoid the extra call to maybereloadengines, this shouldnt have any effect on tests that dont specifically trigger the conditions and try run @ https://treeherder.mozilla.org/jobs?repo=try&classifiedState=unclassified&revision=869fe4d221f00ee367ddd86254005bf30382fc54&selectedTaskRun=Fxa_n_1YTrifRLSBOWINkg.0 with failing tests added is looking green so landing again, 3rd time lucky

Flags: needinfo?(dharvey)
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/feda3aa1dbce
Add Nimbus flag to control Search Private Default. r=Standard8
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
Depends on: 1792673

Comment on attachment 9295200 [details]
Bug 1790790 - Add Nimbus flag to control Search Private Default. r=Standard8

Beta/Release Uplift Approval Request

  • User impact if declined: This is adding more options for experiments.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1792673
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small change that adds extra checks for experiment options, well tested by automated tests.
  • String changes made/needed: No
  • Is Android affected?: No
Attachment #9295200 - Flags: approval-mozilla-beta?

Comment on attachment 9295200 [details]
Bug 1790790 - Add Nimbus flag to control Search Private Default. r=Standard8

Approved for 106.0b6.

Attachment #9295200 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9295200 [details]
Bug 1790790 - Add Nimbus flag to control Search Private Default. r=Standard8

Beta/Release Uplift Approval Request

  • User impact if declined: This is adding more options for experiments.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1792673
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small change that adds extra checks for experiment options, well tested by automated tests.
  • String changes made/needed: None
  • Is Android affected?: No
Attachment #9295200 - Flags: approval-mozilla-release?

This has been tested indirectly as part of experiment testing: marking as verified on Windows 10, Ubuntu 22.04 and Mac 11 using Nightly 107.0a1 (2022-09-29) and Beta 106.0b6.

QA Whiteboard: [qa-triaged]

Comment on attachment 9295200 [details]
Bug 1790790 - Add Nimbus flag to control Search Private Default. r=Standard8

Approved for 105.0.2.

Attachment #9295200 - Flags: approval-mozilla-release? → approval-mozilla-release+

Verified as fixed with 105.0.2 on Ubuntu 22.04, Mac 11 and Windows 10.

QA Whiteboard: [qa-triaged]
Flags: qe-verify+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.