1790790 - Add Nimbus integration for separatePrivateSearch.ui

Status: VERIFIED FIXED

(Firefox :: Search, task, P1)

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 1790790 - Add Nimbus integrations to control separate private default feature. r=Standard8

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1790790 - Add Nimbus flag to control Search Private Default. r=Standard8

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3302226f71f
Add Nimbus flag to control Search Private Default. r=Standard8

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for casuing xpcshell failures on test_defaultEngine_experiments.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&fromchange=d3302226f71f9b0851862900e729c57da71f7773&tochange=aa1973a8680ebe4181ace8a0a76d1a2e05ed9b77&searchStr=xpc&selectedTaskRun=RNvUXRpcSgiWLnPNLW5C1Q.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=391329872&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/aa1973a8680ebe4181ace8a0a76d1a2e05ed9b77

Comment 5

[Dale Harvey (:daleharvey)]

Ah those tests landed after my patch was based so my try push was green, seen the problem and pushed a fix @ https://phabricator.services.mozilla.com/D157605, checking aother try run now

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6031e0a3a0b
Add Nimbus flag to control Search Private Default. r=Standard8

Comment 7

[Atila Butkovits]

Backed out for causing telemetry failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/94436fdd766dbf69bdec71e091ad913d003c971d

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f6031e0a3a0b0c72c7934e1a4bf77870aa290c38&selectedTaskRun=LptLpDV_RnaSR1H5uoCx3Q.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=391389106&repo=autoland&lineNumber=3240

Comment 8

[Dale Harvey (:daleharvey)]

Sorry those tests didnt get run from mach try auto

Refactored the code to avoid the extra call to maybereloadengines, this shouldnt have any effect on tests that dont specifically trigger the conditions and try run @ https://treeherder.mozilla.org/jobs?repo=try&classifiedState=unclassified&revision=869fe4d221f00ee367ddd86254005bf30382fc54&selectedTaskRun=Fxa_n_1YTrifRLSBOWINkg.0 with failing tests added is looking green so landing again, 3rd time lucky

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/feda3aa1dbce
Add Nimbus flag to control Search Private Default. r=Standard8

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/feda3aa1dbce

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 9295200 [details]
Bug 1790790 - Add Nimbus flag to control Search Private Default. r=Standard8

Beta/Release Uplift Approval Request

• User impact if declined: This is adding more options for experiments.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1792673
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change that adds extra checks for experiment options, well tested by automated tests.
• String changes made/needed: No
• Is Android affected?: No

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9295200 [details]
Bug 1790790 - Add Nimbus flag to control Search Private Default. r=Standard8

Approved for 106.0b6.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/98f9293f5563

Comment 14

[Mark Banner (:standard8)]

Comment on attachment 9295200 [details]
Bug 1790790 - Add Nimbus flag to control Search Private Default. r=Standard8

Beta/Release Uplift Approval Request

• User impact if declined: This is adding more options for experiments.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1792673
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change that adds extra checks for experiment options, well tested by automated tests.
• String changes made/needed: None
• Is Android affected?: No

Comment 15

[Adrian Florinescu [:aflorinescu]]

This has been tested indirectly as part of experiment testing: marking as verified on Windows 10, Ubuntu 22.04 and Mac 11 using Nightly 107.0a1 (2022-09-29) and Beta 106.0b6.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9295200 [details]
Bug 1790790 - Add Nimbus flag to control Search Private Default. r=Standard8

Approved for 105.0.2.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/e758a83c7e0e

Comment 18

[Adrian Florinescu [:aflorinescu]]

Verified as fixed with 105.0.2 on Ubuntu 22.04, Mac 11 and Windows 10.