Closed Bug 1790814 Opened 2 years ago Closed 2 years ago

"View Add-ons" and "Manage extension" quick actions appear to be duplicates

Categories

(Firefox :: Address Bar, defect)

defect

Tracking

()

VERIFIED FIXED
107 Branch
Tracking Status
firefox107 --- verified

People

(Reporter: dao, Assigned: daisuke)

References

Details

Attachments

(2 files)

The "View Add-ons" and "Manage extension" quick actions show up together among the top site results. They sound like they'd do the same, and both do in fact appear to just open about:addons. Why do we have these two separate actions doing apparently the same thing?

One opens about:addons and the other opens about:addons on the "Extensions" tab

The behaviour of about:addons is that it saves the last opened tab and restores that, which means if the user just opened the Extensions tab then they will have essentially the same behaviour. The behaviour of "View Add-ons" is that it used to always open on the discover page, that code changed in https://bugzilla.mozilla.org/show_bug.cgi?id=1789322 but I am wondering if we want to revert that change because the current behaviour does seem confusing.

I think if we have an existing about:addons page open when we click any of the about:add-ons quick actions we switch to that tab and load the sections we clicked on, I think opening a new tab on that section is also reasonable if for some reason the previous is hard, but I do think clicking on a quick action should open the same page each time (ie View Add-ons should open list://discover). What do you think Daisuke?

Flags: needinfo?(daisuke)

Yeah, I also understand that.
As the "View Add-ons" does different behavior from other actions that open about:addons, it makes confusion.
For consistency, we may better revert the behavior for "View Add-ons".
I will revert it. Thanks!

Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Flags: needinfo?(daisuke)

And I tested a bit, I prefer opening new tab than switching tab because switching tab but then changing the content makes me confuse a bit.
I will implement the above, then could you check the behavior?

In a trial, I change the behavior to that if we have a tab opened with the same view id (e.g. addons://discover/), select the tab instead of opening a new tab. Please check it after posting my patch.

And one more thing.
When we select menu item Tools -> Add-ons and Themes, opens about:addons in current tab if the current tab is blank. Otherwise, opens a new tab.
So, to keep consistency, let me try to make this behavior match it.

In summary:

  1. If there is a tab opened with the same view id, select it.
  2. If the current tab is blank, load the page in the current tab.
  3. Otherwise, open a new tab and load the page.
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b4b281dd879
'View Add-ons' action shows always 'addons://discover/'. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/a1a01949ec15
Depends on existing tabs to change the tab to open about:addons page. r=daleharvey
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
Depends on: 1792195
No longer depends on: 1792195

The issue is verified fixed on Windows 10 and Ubuntu 22.04 using the latest Fx 107.0a1. This has also been covered as part of the sign off for Fx107.0a1 feature work.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: