Closed Bug 1790819 Opened 2 years ago Closed 2 years ago

Firefox View feature tour third card goes out of view on screen resizing

Categories

(Firefox :: Messaging System, defect, P1)

Desktop
macOS
defect

Tracking

()

VERIFIED FIXED
107 Branch
Iteration:
107.2 - Oct 3 - Oct 14
Tracking Status
firefox107 --- verified

People

(Reporter: asafko, Assigned: aminomancer)

References

(Blocks 2 open bugs)

Details

Attachments

(4 files)

Attached image 1668 × 1534.png

On window resizing, the third card in the callout is scrolled down out of view (you can see its little triangle in the bottom of the 1668x1534 screenshot.

Attached image 1300 × 1110.png
Attached image 3134 × 1948.png

NI @vtay to help clarify if the fix is needed for Fx106 as it impacts narrow windows

Flags: needinfo?(vtay)
Iteration: --- → 107.1 - Sept 19 - Sept 30
Priority: -- → P1
Assignee: nobody → shughes

Triaged with product and ok to keep the fix for Fx107

Flags: needinfo?(vtay)

Try to keep feature callouts within the viewport if possible. Make some
changes to fix a bug where callouts could overflow ~10px over the
available space before being repositioned, and also fix a minor typo
issue. Choose the backup position with the greatest available space
instead of based on the position's order in the positions object.

The severity field is not set for this bug.
:tspurway, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(tspurway)
See Also: → 1792665
Iteration: 107.1 - Sept 19 - Sept 30 → 107.2 - Oct 3 - Oct 14
See Also: → 1792660
Blocks: 1790846
Blocks: 1788702
See Also: 1792660
See Also: 1792665
Pushed by shughes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c49025793d4
Feature callouts: more overflow protection. r=mviar
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (107.0a1 Build ID - 20221010033207) installed on Windows 10 x64, macOS 11.6.7, and Linux Mint 20.2 x64. Now, I can confirm that the third card from the "Firefox View" feature tour is visible if the browser is resized.

Status: RESOLVED → VERIFIED
See Also: → 1795529
Severity: -- → S3
Flags: needinfo?(tspurway)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: