1790835 - Suggest Firefox View with a "hello" spotlight modal

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[hanna A]

We'll launch the spotlight when a user navigates to about:firefoxview

https://www.figma.com/file/mrjF8OroTxjSZglHUjRybQ/Product-tour?node-id=455%3A33696

Comment 1

[hanna A]

Attachment: WIP: Bug 1790835 - Suggest Firefox View with a "hello" spotlight modal

Comment 2

[hanna A]

Attachment: WIP: Bug 1790835 - Suggest Firefox View with a "hello" spotlight modal

Comment 3

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]:

Fix is needed to make spotlight modal show in Fx106

Comment 4

[Punam Dahiya [:pdahiya]]

Scope of this bug involves implementing pref to show spotlight modal as entry point when firefox view first opens instead of feature callout. JSON config can be remotely delivered but need to be tested on local for any edge cases.

Comment 5

[Vtay]

User flow: https://www.figma.com/file/mrjF8OroTxjSZglHUjRybQ/Product-tour?node-id=2295%3A78559

Comment 6

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1790835 - Add Intro Spotlight Modal Screen to Feature Tour

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2fd96a9e3c4
Add Intro Spotlight Modal Screen to Feature Tour r=Mardak

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d2fd96a9e3c4

Comment 9

[Alice Varro [avarro], Ecosystem QA]

I have verified this enhancement using the latest Firefox Nightly 107.0a1 (Build ID: 20220922214429) on Windows 10x64, macOS 12.3.1 and LinuxMint 20.2 x64 and I can confirm the following:

• The "Welcome" spotlight from the "Firefox View" page is successfully displayed at the beginning of the feature callout tour.

Comment 10

[Punam Dahiya [:pdahiya]]

Comment on attachment 9295351 [details]
Bug 1790835 - Add Intro Spotlight Modal Screen to Feature Tour

Beta/Release Uplift Approval Request

• User impact if declined: MR 106 Firefox View Feature Tour uses spotlight modal in the patch as first step of Firefox View Feature Tour
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See https://bugzilla.mozilla.org/show_bug.cgi?id=1790835#c9

• With a new profile open about:welcome, navigate to last screen of new user onboarding, click Whats New primary button should show spotlight modal intro screen above about:firefoxview
• In existing user MR onboarding upgrade dialog, navigate to last screen where click of Whats New primary button should show spotlight modal intro screen above about:firefoxview

Message is frequency capped to lifetime 1 and any subsequent load of about:firefoxview for a profile shouldn't show spotlight modal on about:firefoxview

• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small patch that adds a new message to existing feature tour in beta. Flow is tested and verified in Nightly
• String changes made/needed: none
• Is Android affected?: No

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9295351 [details]
Bug 1790835 - Add Intro Spotlight Modal Screen to Feature Tour

Approved for 106.0b4, thanks.

Comment 12

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/895cc5cc0db2

Comment 13

[Alice Varro [avarro], Ecosystem QA]

I have verified this enhancement using the latest Firefox Beta 106.0b4 (Build ID: 20220925185751) on Windows 10x64, macOS 12.3.1 and LinuxMint 20.2 x64 and I can confirm the following:

• The "Welcome" spotlight from the "Firefox View" page is successfully displayed at the beginning of the feature callout tour.

Comment 14

[Ed Lee :Mardak]

This got turned off in bug 1821826 and to be cleaned up in bug 1828508.