Closed Bug 1790855 Opened 2 years ago Closed 2 years ago

Enable screenshots button on about pages

Categories

(Firefox :: Screenshots, enhancement)

enhancement

Tracking

()

VERIFIED FIXED
107 Branch
Tracking Status
firefox107 --- verified

People

(Reporter: niklas, Assigned: niklas)

References

Details

Attachments

(1 file)

The screenshots component is able to take a screenshot on about pages so the button should reflect that

Blocks: 1789727
Assignee: nobody → nbaumgardner
Status: NEW → ASSIGNED
Attachment #9294712 - Attachment description: WIP: Bug 1790855 - Enable screenshots button on about pages when screenshots component is enabled. sfoster → WIP: Bug 1790855 - Enable screenshots button on about pages when screenshots
Attachment #9294712 - Attachment description: WIP: Bug 1790855 - Enable screenshots button on about pages when screenshots → Bug 1790855 - Enable screenshots button on about pages when screenshots component is enabled. r=sfoster
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d8835c4ab04f
Enable screenshots button on about pages when screenshots component is enabled. r=sfoster

Backed out for causing bc failures in browser/components/screenshots/tests/browser/browser_screenshots_test_toggle_pref.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/eb6b3430f5a3a81ed909d980469928088d22a374

Push with failures

Failure log

INFO - TEST-UNEXPECTED-FAIL | browser/components/screenshots/tests/browser/browser_screenshots_test_toggle_pref.js | Uncaught exception in test - undefined - timed out after 50 tries
Flags: needinfo?(nbaumgardner)
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/45ea391514c0
Enable screenshots button on about pages when screenshots component is enabled. r=sfoster

Backed out for causing bc failures in browser_contextmenu

Backout link: https://hg.mozilla.org/integration/autoland/rev/648bbb463fc64ea1f5226da2d84f56bb99f1dd9f

Push with failures

Failure log

INFO - Buffered messages finished
[task 2022-10-04T03:08:43.404Z] 03:08:43     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/contextMenu/browser_contextmenu.js | checking item #11 (context-viewframesource) name - Got "context-take-frame-screenshot", expected "context-viewframesource"
[task 2022-10-04T03:08:43.404Z] 03:08:43     INFO - Stack trace:
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4447ce0dddaa
Enable screenshots button on about pages when screenshots component is enabled. r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
Regressions: 1793888
Flags: needinfo?(nbaumgardner)
Regressions: 1801360
Regressions: 1802521

Verified as fixed on the latest Nightly 124.0a1 (checked also on Firefox 107.0.1) - the Screenshots button is now enabled on the about pages when the preference 'screenshots.browser.component.enabled' is set to true in about:config. Tested on macOS 13, Ubuntu 22 and Windows 10.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: