1790858 - Perma [tier2] /credential-management/credentialscontainer-create-basics.https.html | single tracking bug

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: apavel [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=390489561&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/bdMOoWvgSW6Crngfpmxigg/runs/0/artifacts/public/logs/live_backing.log

---

[task 2022-09-14T18:07:57.985Z] 18:07:57     INFO - TEST-START | /credential-management/credentialscontainer-create-basics.https.html
[task 2022-09-14T18:07:58.021Z] 18:07:58     INFO - Setting pref security.webauth.webauthn to true
[task 2022-09-14T18:07:58.527Z] 18:07:58     INFO - 
[task 2022-09-14T18:07:58.527Z] 18:07:58     INFO - TEST-UNEXPECTED-PASS | /credential-management/credentialscontainer-create-basics.https.html | navigator.credentials.create() with no argument. - expected FAIL
[task 2022-09-14T18:07:58.527Z] 18:07:58     INFO - TEST-INFO | expected FAIL
[task 2022-09-14T18:07:58.528Z] 18:07:58     INFO - 
[task 2022-09-14T18:07:58.529Z] 18:07:58     INFO - TEST-UNEXPECTED-PASS | /credential-management/credentialscontainer-create-basics.https.html | navigator.credentials.create() with empty argument. - expected FAIL
[task 2022-09-14T18:07:58.531Z] 18:07:58     INFO - TEST-INFO | expected FAIL
[task 2022-09-14T18:07:58.532Z] 18:07:58     INFO - 
[task 2022-09-14T18:07:58.533Z] 18:07:58     INFO - TEST-FAIL | /credential-management/credentialscontainer-create-basics.https.html | navigator.credentials.create() with valid PasswordCredentialData - promise_test: Unhandled rejection with value: object "NotSupportedError: CredentialContainer request is not supported."
[task 2022-09-14T18:07:58.533Z] 18:07:58     INFO - TEST-FAIL | /credential-management/credentialscontainer-create-basics.https.html | navigator.credentials.create() with valid HTMLFormElement - promise_test: Unhandled rejection with value: object "NotSupportedError: CredentialContainer request is not supported."
[task 2022-09-14T18:07:58.533Z] 18:07:58     INFO - TEST-UNEXPECTED-FAIL | /credential-management/credentialscontainer-create-basics.https.html | navigator.credentials.create() with bogus password data - promise_rejects_js: function "function() { throw e }" threw object "NotSupportedError: CredentialContainer request is not supported." ("NotSupportedError") expected instance of function "function TypeError() {
[task 2022-09-14T18:07:58.533Z] 18:07:58     INFO -     [native code]
[task 2022-09-14T18:07:58.533Z] 18:07:58     INFO - }" ("TypeError")
[task 2022-09-14T18:07:58.533Z] 18:07:58     INFO - 
[task 2022-09-14T18:07:58.533Z] 18:07:58     INFO - TEST-FAIL | /credential-management/credentialscontainer-create-basics.https.html | navigator.credentials.create() with valid FederatedCredentialData - promise_test: Unhandled rejection with value: object "NotSupportedError: CredentialContainer request is not supported."
[task 2022-09-14T18:07:58.534Z] 18:07:58     INFO - TEST-UNEXPECTED-FAIL | /credential-management/credentialscontainer-create-basics.https.html | navigator.credentials.create() with bogus federated data - promise_rejects_js: function "function() { throw e }" threw object "NotSupportedError: CredentialContainer request is not supported." ("NotSupportedError") expected instance of function "function TypeError() {
[task 2022-09-14T18:07:58.534Z] 18:07:58     INFO -     [native code]
[task 2022-09-14T18:07:58.534Z] 18:07:58     INFO - }" ("TypeError")
[task 2022-09-14T18:07:58.535Z] 18:07:58     INFO - 
[task 2022-09-14T18:07:58.535Z] 18:07:58     INFO - TEST-PASS | /credential-management/credentialscontainer-create-basics.https.html | navigator.credentials.create() with bogus publicKey data 
[task 2022-09-14T18:07:58.535Z] 18:07:58     INFO - TEST-UNEXPECTED-PASS | /credential-management/credentialscontainer-create-basics.https.html | navigator.credentials.create() with both PasswordCredentialData and FederatedCredentialData - expected FAIL
[task 2022-09-14T18:07:58.536Z] 18:07:58     INFO - TEST-INFO | expected FAIL
[task 2022-09-14T18:07:58.538Z] 18:07:58     INFO - 
[task 2022-09-14T18:07:58.538Z] 18:07:58     INFO - TEST-UNEXPECTED-FAIL | /credential-management/credentialscontainer-create-basics.https.html | navigator.credentials.create() with bogus password and federated data - promise_rejects_js: function "function() { throw e }" threw object "NotSupportedError: CredentialContainer request is not supported." ("NotSupportedError") expected instance of function "function TypeError() {
[task 2022-09-14T18:07:58.538Z] 18:07:58     INFO -     [native code]
[task 2022-09-14T18:07:58.538Z] 18:07:58     INFO - }" ("TypeError")
[task 2022-09-14T18:07:58.540Z] 18:07:58     INFO - 
[task 2022-09-14T18:07:58.540Z] 18:07:58     INFO - TEST-PASS | /credential-management/credentialscontainer-create-basics.https.html | navigator.credentials.create() with bogus federated and publicKey data 
[task 2022-09-14T18:07:58.540Z] 18:07:58     INFO - TEST-PASS | /credential-management/credentialscontainer-create-basics.https.html | navigator.credentials.create() with bogus password and publicKey data 
[task 2022-09-14T18:07:58.540Z] 18:07:58     INFO - TEST-PASS | /credential-management/credentialscontainer-create-basics.https.html | navigator.credentials.create() with bogus password, federated, and publicKey data 
[task 2022-09-14T18:07:58.540Z] 18:07:58     INFO - TEST-UNEXPECTED-PASS | /credential-management/credentialscontainer-create-basics.https.html | navigator.credentials.create() with bogus data - expected FAIL
[task 2022-09-14T18:07:58.540Z] 18:07:58     INFO - TEST-INFO | expected FAIL
[task 2022-09-14T18:07:58.541Z] 18:07:58     INFO - TEST-OK | /credential-management/credentialscontainer-create-basics.https.html | took 543ms
[task 2022-09-14T18:07:58.548Z] 18:07:58     INFO - PID 17899 | 1663178878529	Marionette	INFO	Stopped listening on port 38642
[task 2022-09-14T18:07:58.549Z] 18:07:58     INFO - PID 17899 | [Parent 17899, Main Thread] WARNING: ContentParent: id=7f42b789dd00 - BlockShutdown: NotifyImpendingShutdown.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3623
[task 2022-09-14T18:07:58.550Z] 18:07:58     INFO - PID 17899 | [Parent 17899, Main Thread] WARNING: ContentParent: id=7f42b789dd00 - BlockShutdown: RequestContentJSInterrupt.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3629
[task 2022-09-14T18:07:58.552Z] 18:07:58     INFO - PID 17899 | [Parent 17899, Main Thread] WARNING: ContentParent: id=7f42b65c0600 - BlockShutdown: NotifyImpendingShutdown.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3623
[task 2022-09-14T18:07:58.554Z] 18:07:58     INFO - PID 17899 | [Parent 17899, Main Thread] WARNING: ContentParent: id=7f42b65c0600 - BlockShutdown: RequestContentJSInterrupt.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3629
[task 2022-09-14T18:07:58.556Z] 18:07:58     INFO - PID 17899 | [Parent 17899, Main Thread] WARNING: ContentParent: id=7f42b4d9f100 - BlockShutdown: NotifyImpendingShutdown.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3623
[task 2022-09-14T18:07:58.557Z] 18:07:58     INFO - PID 17899 | [Parent 17899, Main Thread] WARNING: ContentParent: id=7f42b4d9f100 - BlockShutdown: RequestContentJSInterrupt.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3629
[task 2022-09-14T18:07:58.558Z] 18:07:58     INFO - PID 17899 | [Parent 17899, Main Thread] WARNING: ContentParent: id=7f42b4da3c00 - BlockShutdown: NotifyImpendingShutdown.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3623
[task 2022-09-14T18:07:58.559Z] 18:07:58     INFO - PID 17899 | [Parent 17899, Main Thread] WARNING: ContentParent: id=7f42b4da3c00 - BlockShutdown: RequestContentJSInterrupt.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3629
[task 2022-09-14T18:07:58.559Z] 18:07:58     INFO - PID 17899 | [Parent 17899, Main Thread] WARNING: ContentParent: id=7f42ab2c1400 - BlockShutdown: NotifyImpendingShutdown.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3623
[task 2022-09-14T18:07:58.560Z] 18:07:58     INFO - PID 17899 | [Parent 17899, Main Thread] WARNING: ContentParent: id=7f42ab2c1400 - BlockShutdown: RequestContentJSInterrupt.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3629
[task 2022-09-14T18:07:58.826Z] 18:07:58     INFO - PID 17899 | JavaScript error: resource://gre/modules/AsyncShutdown.jsm, line 719: Error: Phase "quit-application-granted" is finished, it is too late to register completion condition "ContentParent: id=7f42a9db2100"
[task 2022-09-14T18:07:58.865Z] 18:07:58     INFO - PID 17899 | [Parent 17899, Main Thread] WARNING: ContentParent: id=7f42ab2c1400 - BlockShutdown: CanSend.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3668
[task 2022-09-14T18:07:58.866Z] 18:07:58     INFO - PID 17899 | [Parent 17899, Main Thread] WARNING: ContentParent: id=7f42ab2c1400 - ShutDownProcess: Sent shutdown message.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1804
[task 2022-09-14T18:07:58.867Z] 18:07:58     INFO - PID 17899 | [Parent 17899, Main Thread] WARNING: ContentParent: id=7f42a9db2100 - BlockShutdown: !CanSend && IsLaunching.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3680
[task 2022-09-14T18:07:58.882Z] 18:07:58     INFO - PID 17899 | [Parent 17899, Main Thread] WARNING: ContentParent: id=7f42ab2c1400 - ShutDownProcess: Closing channel.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1844
[task 2022-09-14T18:07:58.888Z] 18:07:58     INFO - PID 17899 | [Parent 17899, Main Thread] WARNING: ContentParent: id=7f42ab2c1400 - RemoveShutdownBlockers: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3783
[task 2022-09-14T18:07:58.981Z] 18:07:58     INFO - PID 17899 | [Parent 17899, Main Thread] WARNING: ContentParent: id=7f42a9db2100 - ShutDownProcess: Sent shutdown message.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1804
[task 2022-09-14T18:07:58.981Z] 18:07:58     INFO - PID 17899 | [Parent 17899, Main Thread] WARNING: ContentParent: id=7f42a9db2100 - RemoveShutdownBlockers: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:3783
[task 2022-09-14T18:07:59.183Z] 18:07:59     INFO - Browser exited with return code 0

Comment 1

[Andreea Pavel [:apavel]]

Hi Benjamin, can this be a regression of bug 1782085?

Comment 2

[Benjamin VanderSloot [:bvandersloot]]

Yes, I think it is. I'll double check and get a patch together that updates testing/web-platform/meta/credential-management/credentialscontainer-create-basics.https.html.ini to reflect our new PASSes and make sure we don't regress the other tests

Comment 3

[Benjamin VanderSloot [:bvandersloot]]

Looking a hair more closely, the new failures are more correct than the previous PASSes.

They are in test cases when passing incorrect PasswordCredential data. We don't support password credentials and we previously tried to parse that as a WebAuthN credential, which caused the correct kind of error for the test, but wasn't an accurate error for what was actually going on. Marking those as expected failures and removing expected failures for the newly passing tests is a net gain in passing tests and more accurately reflects the state of the codebase.

Comment 4

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1790858 - Update WPT manifest for CredentialContainer to reflect recent changes, r=rmf!

The changes made recently cause some WPT to pass. In particular, those that look for not supported errors.
Some other tests have started failing because they expect TypeErrors from parsing inputs of credentials we do not support.
These were previously passing because the WebAuthN get() parser was giving TypeErrors. It is more correct for us to say these credentials are not supported.

Comment 5

[Intermittent Failures Robot]

38 failures in 3023 pushes (0.013 failures/push) were associated with this bug in the last 7 days.

This is the #13 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-central: 38

Platform and build breakdown:

• linux1804-64-shippable-qr: 16
  • opt: 16
• macosx1015-64-shippable-qr: 10
  • opt: 10
• windows10-64-2004-shippable-qr: 12
  • opt: 12

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1790858&startday=2022-09-12&endday=2022-09-18&tree=all

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3b4eca8da81
Update WPT manifest for CredentialContainer to reflect recent changes, r=rmf

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/a3b4eca8da81

Comment 8

[Intermittent Failures Robot]

6 failures in 2909 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 6

Platform and build breakdown:

• linux1804-64-shippable-qr: 2
  • opt: 2
• windows10-64-2004-shippable-qr: 2
  • opt: 2
• macosx1015-64-shippable-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1790858&startday=2022-09-19&endday=2022-09-25&tree=all