Closed Bug 1790888 Opened 3 months ago Closed 3 months ago

Add some HCM styles for Firefox View

Categories

(Firefox :: Firefox View, defect, P2)

defect

Tracking

()

VERIFIED FIXED
107 Branch
Tracking Status
firefox106 --- verified
firefox107 --- verified

People

(Reporter: aminomancer, Assigned: aminomancer)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: [fidefe-firefox-view] )

Attachments

(1 file)

In HCM, buttons on Firefox View currently don't have the usual hover style (inverted colors). This also affects feature callouts, since these rules override the HCM overrides in common-shared.css. Bug 1790396 will fix this issue for feature callouts, but in order to use consistent properties across all the buttons in HCM, we should also add HCM-specific overrides for these custom properties.

STR

  1. Add a new integer pref ui.useAccessibilityTheme and set to 1
  2. Set browser.firefox-view.feature-tour to {"message":"FIREFOX_VIEW_FEATURE_TOUR","screen":"FEATURE_CALLOUT_1","complete":false}
  3. Go to about:firefoxview
  4. A feature callout should appear
  5. Mouse over the dismiss/close button on the feature callout
  6. Mouse over one of the twisty buttons (the button in the top right of each card that collapses the card)
  7. Open a tab and navigate to some page, then close the tab
  8. Go back to Firefox View
  9. Mouse over the recently closed tab item

Expected

These buttons should have black background and white text/icon

Actual

Buttons have a light gray background and dark text (actually a light gray X icon for the feature callout dismiss button, which makes it invisible)

Has STR: --- → yes

Apply the usual HCM hover style to buttons in Firefox View, but also
override some of the custom properties for HCM so that Emily's patch for
bug 1790396 can use the same custom properties for feature callout hover
styles that we use in system content generally.

Blocks: 1788253

:aminomancer, if you think that's a regression, could you try to find a regression range using for example mozregression?

Severity: -- → S3
Priority: -- → P2
Whiteboard: [fidefe-firefox-view]
Keywords: access
See Also: → 1791074
Blocks: 1791898
Pushed by shughes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea05dc209b54
Add some HCM styles for Firefox View. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch

Any reason not to uplift this to 106?

Flags: needinfo?(shughes)

Comment on attachment 9294728 [details]
Bug 1790888 - Add some HCM styles for Firefox View. r=Gijs!,emcminn!

Beta/Release Uplift Approval Request

  • User impact if declined: Users with contrast themes will have more difficulty seeing buttons on Firefox View.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The patch consists of visual changes affecting only one stylesheet and only with a contrast theme enabled. The only rulesets affected are present in 106 already so it should merge without any issues
  • String changes made/needed:
  • Is Android affected?: No
Flags: needinfo?(shughes)
Attachment #9294728 - Flags: approval-mozilla-beta?

Comment on attachment 9294728 [details]
Bug 1790888 - Add some HCM styles for Firefox View. r=Gijs!,emcminn!

Approved for 106.0b4, thanks.

Attachment #9294728 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]
Flags: qe-verify+

I have verified this issue using the latest Firefox Nightly 107.0a1 (Build ID: 20221002212226) and the latest Firefox Beta 106.0b7 (Build ID: 20221002185807) on Windows 10x64, Windows 11x64, macOS 12.3.1 and Linux Mint 20.2 and I can confirm the following:

  • The buttons from the description have a black background and a white text/icon when hovered.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.