1790989 - Replace ReturnReg moves with storeCallPointerResult

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task)

Description

[André Bargull [:anba]]

Replace masm.mov(ReturnReg, dest) moves with masm.storeCallPointerResult(dest), etc.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1790989 - Part 1: Use storeCallPointerResult to move ReturnReg. r=jandem!

Replaces all mov(ReturnReg, dest) calls with storeCallPointerResult(dest).
This can save an unnecessary move in some cases.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1790989 - Part 2: Use storeCallBoolResult to convert ReturnReg to bool. r=jandem!

Instead of manually calling convertBoolToInt32, use storeCallBoolResult.

Depends on D157458

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1790989 - Part 3: Remove unnecessary storeCallPointerResult. r=jandem!

We can directly tag ReturnReg after a VM-call.

Depends on D157459

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1790989 - Part 4: Use storeCallPointerResult when followed by branchIf{True,False}Bool. r=jandem!

We don't have to use storeCallBoolResult when the result is only used for
branchIf{True,False}Bool. This avoids some extra and bit-masking.

Depends on D157460

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1790989 - Part 5: Use storeCallPointerResult when the result can be used with branchIfTrueBool. r=jandem!

Replacing the branchTest32 with branchIfTrueBool allows to use
storeCallPointerResult here, too.

Depends on D157461

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1790989 - Part 6: Change callWithABI documentation to prefer storeCall{Pointer,Bool,Int32,Float}Result. r=jandem!

Depends on D157462

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/341f4c59c909
Part 1: Use storeCallPointerResult to move ReturnReg. r=jandem
https://hg.mozilla.org/integration/autoland/rev/267dbf24c219
Part 2: Use storeCallBoolResult to convert ReturnReg to bool. r=jandem
https://hg.mozilla.org/integration/autoland/rev/3edb6aed1518
Part 3: Remove unnecessary storeCallPointerResult. r=jandem
https://hg.mozilla.org/integration/autoland/rev/a773b014aa29
Part 4: Use storeCallPointerResult when followed by branchIf{True,False}Bool. r=jandem
https://hg.mozilla.org/integration/autoland/rev/d1cb52b26737
Part 5: Use storeCallPointerResult when the result can be used with branchIfTrueBool. r=jandem
https://hg.mozilla.org/integration/autoland/rev/32b6eb832636
Part 6: Change callWithABI documentation to prefer storeCall{Pointer,Bool,Int32,Float}Result. r=jandem

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/341f4c59c909
https://hg.mozilla.org/mozilla-central/rev/267dbf24c219
https://hg.mozilla.org/mozilla-central/rev/3edb6aed1518
https://hg.mozilla.org/mozilla-central/rev/a773b014aa29
https://hg.mozilla.org/mozilla-central/rev/d1cb52b26737
https://hg.mozilla.org/mozilla-central/rev/32b6eb832636