1791002 - The “Gratitude” screen title has a period

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P2)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: GratitudeTitleHasAPeriod.png

[Affected versions]:

• Firefox Nightly 106.0a1 (Build ID: 20220914213649)

[Affected Platforms]:

• macOS 12.5.1
• Windows 10 x64
• Ubuntu 20.04 x64

[Prerequisites]:

• Have the latest version of the Firefox Nightly build installed and opened.

[Steps to reproduce]:

1. Navigate to the “about:welcome” page.
2. Click the “Skip this step” button until the “Gratitude” screen is displayed.
3. Observe the title of the screen.

[Expected result]:

• The title has no period.

[Actual result]:

• The “You’re helping us build a better web.” title has a period.

[Notes]:

• Attached is a screenshot of the issue.

Comment 1

[Ed Lee :Mardak]

Looks like most locales copied that pattern from en-US https://transvision.flod.org/string/?entity=browser/browser/newtab/onboarding.ftl:mr2022-onboarding-gratitude-title

Comment 2

[Ania]

Is there a way to edit the dot out of all the locales without causing a havoc? Unfortunately, it's a carryover from Figma where the dot was left behind.

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Ania from comment #2)

Is there a way to edit the dot out of all the locales without causing a havoc? Unfortunately, it's a carryover from Figma where the dot was left behind.

Not if we care about other locales updating it as English, and with the time left in the cycle.

My suggestion is to accept the issue for 106. Not completely sure if those strings will be needed for 107+, in case it should be fixed with a new ID.

Comment 4

[Ed Lee :Mardak]

Attachment: Bug 1791002 - The “Gratitude” screen title has a period r?flod

Change the string in place to fix for en-US.

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Ania from comment #2)

Is there a way to edit the dot out of all the locales without causing a havoc?

I realized I misread this.

There's no easy or safe way to edit the dot away from all locales: we're talking about changing a string across 100 separate repositories, with locales that might potentially use different punctuation signs, and translations will keep coming with that period for a while even after we fix en-US (because translations were suggested before).

The proper fix is to land a string without a period and with a new ID, forcing every locale to retranslate. Per conversation on zoom, we can try to fix en-* by just changing the string for now.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/238297f636ec
The “Gratitude” screen title has a period r=flod,fluent-reviewers DONTBUILD

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/238297f636ec

Comment 8

[Francesco Lodolo [:flod]]

Note: I'm going to manually fix a few locales and send a comment for the others.

Comment 9

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this issue using the latest Firefox Nightly 106.0a1 en-US build (Build ID: 20220916033628) on Windows 10 x64, macOS 12.5.1, and Linux Mint 20.2 x64.

• The “Gratitude” screen title has no period.