1791007 - Perma toolkit/components/aboutperformance/tests/browser/browser_aboutperformance.js | Uncaught exception in test when Gecko merges to Beta on 2022-09-19

Status: VERIFIED FIXED

(Toolkit :: Performance Monitoring, defect)

Description

[Noemi Erli[:noemi_erli]]

[Tracking Requested - why for this release]:

• central-as-beta simulation
• How to run these simulations
• Failure log

[task 2022-09-15T11:47:51.906Z] 11:47:51 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/aboutperformance/tests/browser/browser_aboutperformance.js | Uncaught exception in test - at chrome://mochitests/content/browser/toolkit/components/aboutperformance/tests/browser/browser_aboutperformance.js:97 - TypeError: twistyBtn is null
[task 2022-09-15T11:47:51.906Z] 11:47:51 INFO - Stack trace:
[task 2022-09-15T11:47:51.907Z] 11:47:51 INFO - init@chrome://mochitests/content/browser/toolkit/components/aboutperformance/tests/browser/browser_aboutperformance.js:97:18
[task 2022-09-15T11:47:51.907Z] 11:47:51 INFO - Leaving test bound init
[task 2022-09-15T11:47:51.908Z] 11:47:51 INFO - GECKO(18593) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2022-09-15T11:47:51.909Z] 11:47:51 INFO - GECKO(18593) | MEMORY STAT | vsize 11217MB | residentFast 423MB | heapAllocated 180MB
[task 2022-09-15T11:47:51.912Z] 11:47:51 INFO - TEST-OK | toolkit/components/aboutperformance/tests/browser/browser_aboutperformance.js | took 4010ms
[task 2022-09-15T11:47:51.915Z] 11:47:51 INFO - Not taking screenshot here: see the one that was previously logged

Anna, could you please take a look at this?

Comment 1

[Florian Quèze [:florian]]

The difference between Nightly and beta is likely because https://searchfox.org/mozilla-central/rev/0948667bc62415d48abff27e1405fb4ab4d65d75/modules/libpref/init/all.js#4072-4076

Comment 2

[❌ Anna Yeddi [:ayeddi] ❌ On leave until 2027-01-04]

Attachment: Bug 1791007: Catching exception in test for Beta when no Twisty is present. r=florian!

Fixing Perma toolkit/components/aboutperformance/tests/browser/browser_aboutperformance.js | Uncaught exception in test when Gecko merges to Beta on 2022-09-19

Test with pref "toolkit.aboutPerformance.showInternals=false" to have no rows with subitems and trigger the exception.

Comment 3

[❌ Anna Yeddi [:ayeddi] ❌ On leave until 2027-01-04]

Thank you for details, :noemi_erli, and for investigating it, :florian! I submitted the patch and am on a lookout if there's anything else that I can do to fix it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69cd8527dc1b
Catching exception in test for Beta when no Twisty is present. r=florian

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/69cd8527dc1b

Comment 6

[Cosmin Sabou [:CosminS]]

Verified fix in today's beta-sims.