Closed Bug 1791115 Opened 3 years ago Closed 3 years ago

Intermittent TV browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | single tracking bug

Categories

(Firefox :: Firefox View, defect, P5)

Product:
Firefox
Component:
Firefox View
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox105 --- unaffected
firefox106 --- wontfix
firefox107 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: sfoster)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Bug 1791115 - Ensure we switch back to fx-view tab after removing the tab opened in test_time_updates_correctly. r?sclements!
48 bytes, text/x-phabricator-request
Details | Review

Filed by: nfay [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=390630605&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/SMbk7EM8T-2wzqqOvMCjfg/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/SMbk7EM8T-2wzqqOvMCjfg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

[task 2022-09-15T22:54:51.295Z] 22:54:51     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | Got element with selector: #tabpickup-steps - 
[task 2022-09-15T22:54:51.297Z] 22:54:51     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | Got element with selector: #tabpickup-tabs-container - 
[task 2022-09-15T22:54:51.298Z] 22:54:51     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | synced-tab-li-time text is 'Just now' - "Just now" includes "Just now" - 
[task 2022-09-15T22:54:51.299Z] 22:54:51     INFO - Console message: 1663282490540	FirefoxView.TabsSetup	DEBUG	Handling UIState update
[task 2022-09-15T22:54:51.300Z] 22:54:51     INFO - Console message: 1663282490540	FirefoxView.TabsSetup	DEBUG	onSignedInChange, fxaSignedIn:: true
[task 2022-09-15T22:54:51.302Z] 22:54:51     INFO - Console message: 1663282490541	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, conditions not met to exit state: : synced-tabs-loaded
[task 2022-09-15T22:54:51.303Z] 22:54:51     INFO - Console message: 1663282490541	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, will notify update?:: true
[task 2022-09-15T22:54:51.304Z] 22:54:51     INFO - Console message: 1663282490545	FirefoxView.TabsSetup	DEBUG	refreshDevices, mobileDeviceConnected: true, : secondaryDeviceConnected: true
[task 2022-09-15T22:54:51.305Z] 22:54:51     INFO - Console message: 1663282490545	FirefoxView.TabsSetup	DEBUG	refreshDevices: device state did change
[task 2022-09-15T22:54:51.307Z] 22:54:51     INFO - Console message: 1663282490545	FirefoxView.TabsSetup	DEBUG	onSignedInChange, after refreshDevices, calling maybeUpdateUI
[task 2022-09-15T22:54:51.308Z] 22:54:51     INFO - Console message: 1663282490545	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, conditions not met to exit state: : synced-tabs-loaded
[task 2022-09-15T22:54:51.309Z] 22:54:51     INFO - Console message: 1663282490545	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, will notify update?:: false
[task 2022-09-15T22:54:51.310Z] 22:54:51     INFO - Console message: 1663282490545	FirefoxView.TabsSetup	DEBUG	onSignedInChange, tabSyncNeeded:: false
[task 2022-09-15T22:54:51.311Z] 22:54:51     INFO - Console message: 1663282490546	FirefoxView.TabsSetup	DEBUG	Handling weave:service:sync:finish
[task 2022-09-15T22:54:51.312Z] 22:54:51     INFO - Console message: 1663282490546	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, conditions not met to exit state: : synced-tabs-loaded
[task 2022-09-15T22:54:51.313Z] 22:54:51     INFO - Console message: 1663282490546	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, will notify update?:: false
[task 2022-09-15T22:54:51.315Z] 22:54:51     INFO - Console message: [JavaScript Error: "TypeError: can't access property "status", state is null" {file: "resource://services-sync/UIState.jsm" line: 199}]
[task 2022-09-15T22:54:51.315Z] 22:54:51     INFO - _setLastSyncTime@resource://services-sync/UIState.jsm:199:9
[task 2022-09-15T22:54:51.316Z] 22:54:51     INFO - toggleSyncActivity@resource://services-sync/UIState.jsm:134:10
[task 2022-09-15T22:54:51.317Z] 22:54:51     INFO - observe@resource://services-sync/UIState.jsm:102:14
[task 2022-09-15T22:54:51.317Z] 22:54:51     INFO - setupListState@chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/head.js:311:16
[task 2022-09-15T22:54:51.318Z] 22:54:51     INFO - 
[task 2022-09-15T22:54:51.319Z] 22:54:51     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | synced-tab-li-time text has updated - 
[task 2022-09-15T22:54:51.321Z] 22:54:51     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | parent must be in snapshot. Has [parent]. - true == true - 
[task 2022-09-15T22:54:51.322Z] 22:54:51     INFO - Buffered messages finished
[task 2022-09-15T22:54:51.323Z] 22:54:51     INFO - TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | After filtering we must have the expected number of events. - 4 == 3 - JS frame :: resource://testing-common/TelemetryTestUtils.jsm :: assertEvents :: line 241
[task 2022-09-15T22:54:51.324Z] 22:54:51     INFO - Stack trace:
[task 2022-09-15T22:54:51.324Z] 22:54:51     INFO - resource://testing-common/TelemetryTestUtils.jsm:assertEvents:241
[task 2022-09-15T22:54:51.324Z] 22:54:51     INFO - chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js:test_time_updates_correctly/<:381
[task 2022-09-15T22:54:51.326Z] 22:54:51     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | category in event firefoxview#entered#firefoxview must match. - "firefoxview" matches "firefoxview" - 
[task 2022-09-15T22:54:51.327Z] 22:54:51     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | method in event firefoxview#entered#firefoxview must match. - "entered" matches "entered" - 
[task 2022-09-15T22:54:51.329Z] 22:54:51     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | object in event firefoxview#entered#firefoxview must match. - "firefoxview" matches "firefoxview" - 
[task 2022-09-15T22:54:51.330Z] 22:54:51     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | category in event firefoxview#synced_tabs#tabs must match. - "firefoxview" matches "firefoxview" - 
[task 2022-09-15T22:54:51.331Z] 22:54:51     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | method in event firefoxview#synced_tabs#tabs must match. - "synced_tabs" matches "synced_tabs" - 
[task 2022-09-15T22:54:51.333Z] 22:54:51     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | object in event firefoxview#synced_tabs#tabs must match. - "tabs" matches "tabs" - 
[task 2022-09-15T22:54:51.334Z] 22:54:51     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | Actual event firefoxview#synced_tabs#tabs expected to have extra. - true == true - 
[task 2022-09-15T22:54:51.335Z] 22:54:51     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | Expected key count must be in actual extra. Actual keys: [count]. - true == true - 
[task 2022-09-15T22:54:51.336Z] 22:54:51     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | extra[count] must match in event firefoxview#synced_tabs#tabs. - "1" matches "1" - 
[task 2022-09-15T22:54:51.337Z] 22:54:51     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | category in event firefoxview#tab_pickup_open#tabs must match. - "firefoxview" matches "firefoxview" - 
[task 2022-09-15T22:54:51.338Z] 22:54:51     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-09-15T22:54:51.340Z] 22:54:51     INFO - TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | method in event firefoxview#tab_pickup_open#tabs must match. - "tab_pickup_open" matches "tab_pickup" - JS frame :: resource://testing-common/TelemetryTestUtils.jsm :: assertEvents :: line 276
[task 2022-09-15T22:54:51.340Z] 22:54:51     INFO - Stack trace:
[task 2022-09-15T22:54:51.340Z] 22:54:51     INFO - resource://testing-common/TelemetryTestUtils.jsm:assertEvents:276
[task 2022-09-15T22:54:51.342Z] 22:54:51     INFO - chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js:test_time_updates_correctly/<:381
[task 2022-09-15T22:54:51.343Z] 22:54:51     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | object in event firefoxview#tab_pickup_open#tabs must match. - "tabs" matches "tabs" - 
[task 2022-09-15T22:54:51.344Z] 22:54:51     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | Actual event firefoxview#tab_pickup_open#tabs expected to have extra. - true == true - 
[task 2022-09-15T22:54:51.346Z] 22:54:51     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-09-15T22:54:51.348Z] 22:54:51     INFO - TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | Uncaught exception in test - at resource://testing-common/TelemetryTestUtils.jsm:298 - TypeError: right-hand side of 'in' should be an object, got undefined
[task 2022-09-15T22:54:51.348Z] 22:54:51     INFO - Stack trace:
[task 2022-09-15T22:54:51.348Z] 22:54:51     INFO - assertEvents@resource://testing-common/TelemetryTestUtils.jsm:298:1
[task 2022-09-15T22:54:51.349Z] 22:54:51     INFO - test_time_updates_correctly/<@chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js:381:26
[task 2022-09-15T22:54:51.351Z] 22:54:51     INFO - Leaving test bound test_time_updates_correctly
[task 2022-09-15T22:54:51.352Z] 22:54:51     INFO - GECKO(1625) | JavaScript error: resource:///modules/AsyncTabSwitcher.jsm, line 378: TypeError: can't access property "schemeIs", requestedBrowser.currentURI is null
[task 2022-09-15T22:54:51.354Z] 22:54:51     INFO - Console message: [JavaScript Error: "TypeError: can't access property "schemeIs", requestedBrowser.currentURI is null" {file: "resource:///modules/AsyncTabSwitcher.jsm" line: 378}]
[task 2022-09-15T22:54:51.354Z] 22:54:51     INFO - updateDisplay@resource:///modules/AsyncTabSwitcher.jsm:378:26
[task 2022-09-15T22:54:51.354Z] 22:54:51     INFO - postActions@resource:///modules/AsyncTabSwitcher.jsm:673:10
[task 2022-09-15T22:54:51.355Z] 22:54:51     INFO - handleEvent@resource:///modules/AsyncTabSwitcher.jsm:1127:12
[task 2022-09-15T22:54:51.355Z] 22:54:51     INFO - 
[task 2022-09-15T22:54:51.357Z] 22:54:51     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "https://example.com/" line: 0}]
[task 2022-09-15T22:54:51.661Z] 22:54:51     INFO - GECKO(1625) | MEMORY STAT | vsize 11475MB | residentFast 559MB | heapAllocated 295MB
[task 2022-09-15T22:54:51.663Z] 22:54:51     INFO - TEST-OK | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | took 2918ms
[task 2022-09-15T22:54:51.665Z] 22:54:51     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-09-15T22:54:51.666Z] 22:54:51     INFO - TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | Found an unexpected tab at the end of test run: https://example.com/ - 
[task 2022-09-15T22:54:51.678Z] 22:54:51     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-09-15T22:54:51.678Z] 22:54:51     INFO - TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | Found an unexpected tab at the end of test run: about:firefoxview - 
[task 2022-09-15T22:54:51.735Z] 22:54:51     INFO - checking window state
[task 2022-09-15T22:54:51.768Z] 22:54:51     INFO - GECKO(1625) | Completed ShutdownLeaks collections in process 1625
[task 2022-09-15T22:54:51.770Z] 22:54:51     INFO - TEST-START | Shutdown

:sfoster, since you are the author of the regressor, bug 1789885, could you take a look?

For more information, please visit auto_nag documentation.

Flags: needinfo?(sfoster)

Yeah I ran into this while implementing the patch on bug 1789885. I thought I had it fixed, but apparently only locally.

Assignee: nobody → sfoster
Status: NEW → ASSIGNED
Component: General → Firefox View
Flags: needinfo?(sfoster)

Set release status flags based on info from the regressing bug 1789885

status-firefox105: --- → unaffected
status-firefox106: --- → affected
status-firefox107: --- → affected
status-firefox-esr102: --- → unaffected
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a2d375baf46 Ensure we switch back to fx-view tab after removing the tab opened in test_time_updates_correctly. r=sclements

https://hg.mozilla.org/mozilla-central/rev/8a2d375baf46

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox107: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch

The patch landed in nightly and beta is affected.
:sfoster, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox106 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(sfoster)

This patch only affects a test, there's no end-user value in uplifting it.

status-firefox106: affected → wontfix
Flags: needinfo?(sfoster)
See Also: → 1794435
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: