1791172 - [Colorway Closet] The checkmark’s framing is disproportional on some locales when reducing the browser’s width if “Firefox Home is now your homepage” translation generates a long string

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect, P2)

Description

[Anca Soncutean, Desktop QA]

Attachment: screencast issue.mov

Found in

• 106.0a1

Affected versions

• 106.0a1

Affected platforms

• macOS 11
• Windows 10
• Ubuntu 20

Preconditions

• Have a locale build installed that we’ll generate a long string once “Firefox Home is now your homepage” is translated (eg. it, fr, hu, ru).
• In about:config set:
  • "browser.theme.colorway-closet" to true
  • "browser.tabs.firefox-view" to true

Steps to reproduce

1. Set a custom home page in about:preferences
2. Open Colorways modal from FxView or from about:addons
3. Click on the Apply button.
4. Reduce the width of the browser considerable

Expected result

• The checkmark has a good space proportion, no overlapping occurs.

Actual result

• The checkmark’s framing is disproportional; the [Set colorway] button is overlapped.

Regression range

• This behaviour is generated by the length of the “Firefox Home is now your homepage” string translation.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1789625

Comment 2

[Amy Churchwell [:amy]]

Attachment: Bug 1791172 - Reposition homepage success checkmark. r=dao

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16b9af4e4bec
Reposition homepage success checkmark. r=kpatenio

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/16b9af4e4bec

Comment 5

[Anca Soncutean, Desktop QA]

Verified fixed with Fx 107.0a1 (2022-10-14) on Windows 10, macOS 12 and Ubuntu 22.04.

Comment 6

[Dão Gottwald [:dao]]

It looks like this reverted parts of bug 1789625's patch that were crucial to fixing that bug. Can you please retest and confirm or deny my observation?

Comment 7

[Hani Yacoub, Desktop QA]

I just checked on the latest Firefox Nightly on Windows 10 x64, macOS 11.6 and on Ubuntu 20.04 x64 and I didn't notice anything weird. The checkmark has a good space proportion, no overlapping occurs when reducing the browser’s width.

Comment 8

[Dão Gottwald [:dao]]

Attachment: Screenshot from 2022-11-01 16-50-52.png

(In reply to Hani Yacoub from comment #7)

I just checked on the latest Firefox Nightly on Windows 10 x64, macOS 11.6 and on Ubuntu 20.04 x64 and I didn't notice anything weird. The checkmark has a good space proportion, no overlapping occurs when reducing the browser’s width.

Bug 1789625 wasn't about overlapping but about vertical alignment (without reducing the browser to an extreme width). Over here on Ubuntu the alignment with the text seems off, see the attached screenshot. Are you seeing something else?

Comment 9

[Hani Yacoub, Desktop QA]

I can notice the misalignment on Win10, macOS 11.6 and on Ubuntu 20.04. The success checkmark should be raised a little bit to be perfectly aligned with text.

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing reggression in bug 1789625

Backout link: https://hg.mozilla.org/integration/autoland/rev/618673963f3c3bba2283f2a6589f9992fa40ffda

Comment 11

[Sandor Molnar[:smolnar]]

Backout merged to central

Backout link: https://hg.mozilla.org/mozilla-central/rev/16b9af4e4bec

Comment 12

[Dão Gottwald [:dao]]

(In reply to Sandor Molnar from comment #11)

Backout merged to central

Backout link: https://hg.mozilla.org/mozilla-central/rev/16b9af4e4bec

This was the original patch landing. Here's the real backout link: https://hg.mozilla.org/mozilla-central/rev/618673963f3c3bba2283f2a6589f9992fa40ffda

So that did land in 108, meaning that the broken fix is still in 107. We should probably back out there too. :/

Comment 13

[Donal Meehan [:dmeehan]]

Backout of beta
https://hg.mozilla.org/releases/mozilla-beta/rev/ed1388cd1b00

Comment 14

[Dão Gottwald [:dao]]

Thanks!

Comment 15

[Amy Churchwell [:amy]]

Marking this bug as invalid because there was a decision to sunset the colorways feature.