1791224 - Make `CreateNodeResultBase` treated as ok type of `Result`

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P3)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1791224 - Use `CreateNodeResultBase` as the ok type of `mozilla::Result` r=m_kato!

Similar to the previous patch, this changes a lot of lines. However, I think
that it's not so hard to investigate regression point in this patch because
CreateNodeResultBase is not used so many times at handling on edit action.

Depends on D157574

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/865c5d292958
Use `CreateNodeResultBase` as the ok type of `mozilla::Result` r=m_kato

Comment 3

[Atila Butkovits]

Backed out for causing build bustages at Result.h.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a2319e1da79d8239e7ecf2f758fc8458214d7c8f

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=Dun81XQjQxiA2nKgeTn7pQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=865c5d2929582c30a6808b6c95d9b3b36f637c5d

Failure log: https://treeherder.mozilla.org/logviewer?job_id=391547918&repo=autoland&lineNumber=15644

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67a6d96aa5f9
Use `CreateNodeResultBase` as the ok type of `mozilla::Result` r=m_kato

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Atila Butkovits from comment #3)

Backed out for causing build bustages at Result.h.

It was caused by noexcpt keyword of the move constructor which was warned and suggested by clang-tidy. I don't know why it's error only when building build-linux64-base-toolchains/debug.

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/67a6d96aa5f9