Make `CreateNodeResultBase` treated as ok type of `Result`
Categories
(Core :: DOM: Editor, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox107 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file)
|
Assignee | |
Comment 1•2 years ago
|
||
Similar to the previous patch, this changes a lot of lines. However, I think
that it's not so hard to investigate regression point in this patch because
CreateNodeResultBase is not used so many times at handling on edit action.
Depends on D157574
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/865c5d292958 Use `CreateNodeResultBase` as the ok type of `mozilla::Result` r=m_kato
|
||
Comment 3•2 years ago
|
||
Backed out for causing build bustages at Result.h.
Backout link: https://hg.mozilla.org/integration/autoland/rev/a2319e1da79d8239e7ecf2f758fc8458214d7c8f
Failure log: https://treeherder.mozilla.org/logviewer?job_id=391547918&repo=autoland&lineNumber=15644
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/67a6d96aa5f9 Use `CreateNodeResultBase` as the ok type of `mozilla::Result` r=m_kato
|
|
Assignee | |
Comment 5•2 years ago
|
||
(In reply to Atila Butkovits from comment #3)
Backed out for causing build bustages at Result.h.
It was caused by noexcpt keyword of the move constructor which was warned and suggested by clang-tidy. I don't know why it's error only when building build-linux64-base-toolchains/debug.
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
Description
•