Avoid parent query when file entryId is known
Categories
(Core :: DOM: File, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox107 | --- | fixed |
People
(Reporter: jjalkanen, Assigned: jjalkanen)
Details
Attachments
(3 files)
File system entries can be queried
- with entry's name and its parent's entryId, usually from a directory handle when the caller doesn't yet have a handle to the child item, or
- directly with the entryId when the caller has already obtained a handle and wants to act on the item pointed by the handle.
By providing an overload of DoesDirectory/FileExist functions to cover the second case, a query of the parent entryId can be avoided in the move-related calls, and further down the road, in quota usage related functions.
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
|
Assignee | |
Comment 3•2 years ago
|
||
Depends on D157646
Pushed by jjalkanen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/68253907138d Have rootId constant available in file system database manager. r=dom-storage-reviewers,jesup,janv https://hg.mozilla.org/integration/autoland/rev/328a3402a06d Return error from FileSystemDatabaseManager on request to list deleted folders. r=dom-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/bf28018e2e2a Avoid parent queries for known entries. r=dom-storage-reviewers,jesup
|
||
Comment 5•2 years ago
|
||
Backed out for causing bustages at FileSystemDatabaseManagerVersion001.cpp.
Backout link: https://hg.mozilla.org/integration/autoland/rev/439b15429f7ce1ed970af95e7417b4f232333a21
Failure log: https://treeherder.mozilla.org/logviewer?job_id=391059061&repo=autoland&lineNumber=9779
|
|
Assignee | |
Comment 6•2 years ago
|
||
Some kind of conflict with D157643 was feared: it had begun landing on the same day.
Pushed by jjalkanen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/773a2b7c52da Have rootId constant available in file system database manager. r=dom-storage-reviewers,jesup,janv https://hg.mozilla.org/integration/autoland/rev/482fa41be849 Return error from FileSystemDatabaseManager on request to list deleted folders. r=dom-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/4c7e266ad367 Avoid parent queries for known entries. r=dom-storage-reviewers,jesup
|
||
Comment 8•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/773a2b7c52da
https://hg.mozilla.org/mozilla-central/rev/482fa41be849
https://hg.mozilla.org/mozilla-central/rev/4c7e266ad367
Description
•