Closed Bug 1791347 Opened 2 years ago Closed 2 years ago

Display of macOS/LDAP contacts is broken

Categories

(Thunderbird :: Address Book, defect)

defect

Tracking

(thunderbird_esr102 fixed)

RESOLVED FIXED
106 Branch
Tracking Status
thunderbird_esr102 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Every selection of a contact from an LDAP or macOS address book logs the following error:

JavaScript error: chrome://messenger/content/addressbook/aboutAddressBook.js, line 3205: TypeError: can't access property "getAllValues", card.vCardProperties is null

This is the _screenNamesToIMPPs function which hasn't accounted for cards that do not support vCardProperties.

Target Milestone: --- → 106 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/01993715625a
Fix display of LDAP/macOS contacts. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Good for 102?

102 is unaffected so far, this was caused by bug 1789990 which is not yet on 102.

Comment on attachment 9295216 [details]
Bug 1791347 - Fix display of LDAP/macOS contacts. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1789990
User impact if declined: Address Book display of contacts broken
Testing completed (on c-c, etc.): in 106.0b1
Risk to taking this patch (and alternatives if risky): low

Attachment #9295216 - Flags: approval-comm-esr102?

Comment on attachment 9295216 [details]
Bug 1791347 - Fix display of LDAP/macOS contacts. r=#thunderbird-reviewers

[Triage Comment]
approved for esr102

Attachment #9295216 - Flags: approval-comm-esr102? → approval-comm-esr102+

Bug 1789990 won't uplift to c-esr102 because bug 1776706 is not upliftable due to string changes. This bug is not applicable to c-esr102 unless that all changes.

Flags: needinfo?(rob)
Flags: needinfo?(rob)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: