1791347 - Display of macOS/LDAP contacts is broken

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Geoff Lankow (:darktrojan)]

Every selection of a contact from an LDAP or macOS address book logs the following error:

JavaScript error: chrome://messenger/content/addressbook/aboutAddressBook.js, line 3205: TypeError: can't access property "getAllValues", card.vCardProperties is null

This is the _screenNamesToIMPPs function which hasn't accounted for cards that do not support vCardProperties.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1791347 - Fix display of LDAP/macOS contacts. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/01993715625a
Fix display of LDAP/macOS contacts. r=mkmelin

Comment 3

[Wayne Mery (:wsmwk)]

Good for 102?

Comment 4

[Geoff Lankow (:darktrojan)]

102 is unaffected so far, this was caused by bug 1789990 which is not yet on 102.

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9295216 [details]
Bug 1791347 - Fix display of LDAP/macOS contacts. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1789990
User impact if declined: Address Book display of contacts broken
Testing completed (on c-c, etc.): in 106.0b1
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9295216 [details]
Bug 1791347 - Fix display of LDAP/macOS contacts. r=#thunderbird-reviewers

[Triage Comment]
approved for esr102

Comment 7

[Rob Lemley [:rjl]]

Bug 1789990 won't uplift to c-esr102 because bug 1776706 is not upliftable due to string changes. This bug is not applicable to c-esr102 unless that all changes.

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 102.3.2:
https://hg.mozilla.org/releases/comm-esr102/rev/cbf94a7c5bc3