Open Bug 1791350 Opened 10 days ago Updated 8 days ago

Remove nsIAppStartup shuttingDown property and replace uses with isInOrBeyondShutdownPhase

Categories

(Toolkit :: General, task)

task

Tracking

()

ASSIGNED

People

(Reporter: jstutte, Assigned: jstutte)

References

Details

(Keywords: leave-open)

Attachments

(2 files)

The shuttingDown property is based on mShuttingDown which is designed to be a Quit method reentrancy check. We want to make it be based on AppShutdown::IsInOrBeyond instead.

And in C++ we want to prefer the direct use of AppShutdown::IsInOrBeyond

if (!AppShutdown::IsInOrBeyond(ShutdownPhase::AppShutdownConfirmed)) {

Apart from harmonization with other places, Bug 1726813 gives an additional motivation why this is better (for xpcshell tests).

Keywords: leave-open
Assignee: nobody → jstutte
Status: NEW → ASSIGNED
See Also: → 1754104, 1726813
Attachment #9295219 - Attachment description: Bug 1791350 - Replace Services.startup.shuttingDown with appropriate isInOrBeyondShutdownPhase when scheduling idle or best effort tasks. r?florian → Bug 1791350 - Make Services.startup.shuttingDown be based on AppShutdown::isInOrBeyond. r?florian
See Also: → 1791414
Pushed by jstutte@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a7aa2f529bf
Make Services.startup.shuttingDown be based on AppShutdown::isInOrBeyond. r=florian
https://hg.mozilla.org/integration/autoland/rev/f41eb293fa5b
Replace C++ uses of Services.startup.shuttingDown with appropriate AppShutdown::IsInOrBeyond. r=florian
You need to log in before you can comment on or make changes to this bug.