Closed Bug 1791383 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 35947 - Cycle detection registered custom properties with lh units

Tracking

()

Status:

RESOLVED FIXED

Milestone:

107 Branch

Tracking Flags:

Tracking

Status

firefox107

---

fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Description

•

2 years ago

Sync web-platform-tests PR 35947 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35947
Details from upstream follow.

Rune Lillesveen <futhark@chromium.org> wrote:

Cycle detection registered custom properties with lh units

Like for font-relative properties, using lh units in registered custom
properties referenced in the line-height property may cause cycles.
Detect and correctly handle such cycles.

Bug: 937104
Change-Id: Id2197400addb2f67750b1e2563410ca6cf5319d1
Reviewed-on: https://chromium-review.googlesource.com/3904621
WPT-Export-Revision: a843a907994fe095ec7d9504da245118141210ad

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 years ago

Component: web-platform-tests → CSS Parsing and Computation

Product: Testing → Core

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

2 years ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=81063229414fa5cd4c9f5c4a8d7bbf984f2474ac

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

2 years ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=85f2e2c97fe31e521eca9f1b5745e008be8d1fc6

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 3

•

2 years ago

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 23 subtests

Status Summary

Firefox

OK : 1
FAIL : 62
ERROR: 1

Chrome

OK : 2
PASS : 74
FAIL : 11

Safari

OK : 1
FAIL : 62
ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-properties-values-api/registered-property-computation.html [wpt.fyi]
- <length> values computed are correctly via var()-reference: FAIL (Chrome: PASS, Safari: FAIL)
- <length> values computed are correctly via var()-reference when font-size is inherited: FAIL (Chrome: PASS, Safari: FAIL)
- <length> values are computed correctly when font-size is inherited [14em]: FAIL (Chrome: PASS, Safari: FAIL)
- <length> values are computed correctly when font-size is inherited [calc(14em + 10px)]: FAIL (Chrome: PASS, Safari: FAIL)
- <length> values are computed correctly [12px]: FAIL (Chrome: PASS, Safari: FAIL)
- <length> values are computed correctly [13vw]: FAIL (Chrome: PASS, Safari: FAIL)
- <length> values are computed correctly [14em]: FAIL (Chrome: PASS, Safari: FAIL)
- <length> values are computed correctly [15vmin]: FAIL (Chrome: PASS, Safari: FAIL)
- <length> values are computed correctly [calc(16px - 7em + 10vh)]: FAIL (Chrome: PASS, Safari: FAIL)
- <length> values are computed correctly [1in]: FAIL (Chrome: PASS, Safari: FAIL)
- <length> values are computed correctly [2.54cm]: FAIL (Chrome: PASS, Safari: FAIL)
- <length> values are computed correctly [25.4mm]: FAIL (Chrome: PASS, Safari: FAIL)
- <length> values are computed correctly [6pc]: FAIL (Chrome: PASS, Safari: FAIL)
- <length> values are computed correctly [72pt]: FAIL (Chrome: PASS, Safari: FAIL)
- <length> values are computed correctly [10lh]: FAIL (Chrome: FAIL, Safari: FAIL)
- <length-percentage> values are computed correctly [17em]: FAIL (Chrome: PASS, Safari: FAIL)
- <length-percentage> values are computed correctly [18%]: FAIL (Chrome: PASS, Safari: FAIL)
- <length-percentage> values are computed correctly [calc(19em - 2%)]: FAIL (Chrome: PASS, Safari: FAIL)
- <length># values are computed correctly [10px, 3em]: FAIL (Chrome: PASS, Safari: FAIL)
- <length># values are computed correctly [4em ,9px]: FAIL (Chrome: PASS, Safari: FAIL)
- <length># values are computed correctly [8em]: FAIL (Chrome: PASS, Safari: FAIL)
- <length-percentage># values are computed correctly [3% , 10vmax , 22px]: FAIL (Chrome: PASS, Safari: FAIL)
- <length-percentage># values are computed correctly [calc(50% + 1em), 4px]: FAIL (Chrome: PASS, Safari: FAIL)
- <length-percentage># values are computed correctly [calc(13% + 37px)]: FAIL (Chrome: PASS, Safari: FAIL)
- <length>+ values are computed correctly [10px 3em]: FAIL (Chrome: PASS, Safari: FAIL)
- <length>+ values are computed correctly [4em 9px]: FAIL (Chrome: PASS, Safari: FAIL)
- <length-percentage>+ values are computed correctly [3% 10vmax 22px]: FAIL (Chrome: PASS, Safari: FAIL)
- <length-percentage>+ values are computed correctly [calc(50% + 1em) 4px]: FAIL (Chrome: PASS, Safari: FAIL)
- <transform-function> values are computed correctly [translateX(2px)]: FAIL (Chrome: FAIL, Safari: FAIL)
- <transform-function> values are computed correctly [translateX(10em)]: FAIL (Chrome: FAIL, Safari: FAIL)
- <transform-function> values are computed correctly [translateX(calc(11em + 10%))]: FAIL (Chrome: FAIL, Safari: FAIL)
- <transform-function>+ values are computed correctly [translateX(10%) scale(2)]: FAIL (Chrome: FAIL, Safari: FAIL)
- <integer> values are computed correctly [15]: FAIL (Chrome: PASS, Safari: FAIL)
- <integer> values are computed correctly [calc(15 + 15)]: FAIL (Chrome: PASS, Safari: FAIL)
- <integer> values are computed correctly [calc(2.4)]: FAIL (Chrome: PASS, Safari: FAIL)
- <integer> values are computed correctly [calc(2.6)]: FAIL (Chrome: PASS, Safari: FAIL)
- <integer> values are computed correctly [calc(2.6 + 3.1)]: FAIL (Chrome: PASS, Safari: FAIL)
- <integer>+ values are computed correctly [15 calc(2.4) calc(2.6)]: FAIL (Chrome: PASS, Safari: FAIL)
- <color> values are computed correctly [#ff0000]: FAIL (Chrome: PASS, Safari: FAIL)
- <color> values are computed correctly [#000f00]: FAIL (Chrome: PASS, Safari: FAIL)
- <color> values are computed correctly [#00000a]: FAIL (Chrome: PASS, Safari: FAIL)
- <color> values are computed correctly [#badbee]: FAIL (Chrome: PASS, Safari: FAIL)
- <color> values are computed correctly [#badbee33]: FAIL (Chrome: PASS, Safari: FAIL)
- <color> values are computed correctly [tomato]: FAIL (Chrome: PASS, Safari: FAIL)
- <color> values are computed correctly [plum]: FAIL (Chrome: PASS, Safari: FAIL)
- <color> values are computed correctly [currentcolor]: FAIL (Chrome: PASS, Safari: FAIL)
- - values are computed correctly [tomato]: FAIL (Chrome: PASS, Safari: FAIL)
- tomato | plum values are computed correctly [plum]: FAIL (Chrome: PASS, Safari: FAIL)
- tomato | plum | <color> values are computed correctly [plum]: FAIL (Chrome: PASS, Safari: FAIL)
- - values are computed correctly [-50grad]: FAIL (Chrome: PASS, Safari: FAIL)
- <angle> values are computed correctly [180deg]: FAIL (Chrome: PASS, Safari: FAIL)
- <angle> values are computed correctly [400grad]: FAIL (Chrome: PASS, Safari: FAIL)
- <angle> values are computed correctly [calc(360deg + 400grad)]: FAIL (Chrome: PASS, Safari: FAIL)
- - values are computed correctly [50s]: FAIL (Chrome: PASS, Safari: FAIL)
- <time> values are computed correctly [1s]: FAIL (Chrome: PASS, Safari: FAIL)
- <time> values are computed correctly [1000ms]: FAIL (Chrome: PASS, Safari: FAIL)
- <time> values are computed correctly [calc(1000ms + 1s)]: FAIL (Chrome: PASS, Safari: FAIL)
- - values are computed correctly [50dpi]: FAIL (Chrome: PASS, Safari: FAIL)
- <resolution> values are computed correctly [1dppx]: FAIL (Chrome: PASS, Safari: FAIL)
- <resolution> values are computed correctly [96dpi]: FAIL (Chrome: PASS, Safari: FAIL)
- <resolution> values are computed correctly [calc(1dppx + 96dpi)]: FAIL (Chrome: FAIL, Safari: FAIL)
- - values are computed correctly [url(why)]: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-properties-values-api/unit-cycles.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 years ago

Depends on: 1791857

Pulsebot

Comment 4

•

2 years ago

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f52bd28ff3b5
[wpt PR 35947] - Cycle detection registered custom properties with lh units, a=testonly

Marian-Vasile Laza

Comment 5

•

2 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/f52bd28ff3b5

Status: NEW → RESOLVED

Closed: 2 years ago

status-firefox107: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 107 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Quick Search

[wpt-sync] Sync PR 35947 - Cycle detection registered custom properties with lh units

Categories

(Core :: CSS Parsing and Computation, task, P4)

Tracking

()

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Updated

Comment 1

Comment 2

Comment 3

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

Updated

Comment 4

Comment 5