1791633 - separate TLS socket control from transport security info

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

The TLS socket control implementation (until now called nsISSLSocketControl, soon to be called nsITLSSocketControl) should be separate from the transport security info implementation (nsITransportSecurityInfo).

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: WIP: Bug 1791633 - don't serialize securityInfo in browser_aboutCertError_exception.js r?Gijs

(This test only needs the bytes of the server certificate, not the entire
nsITransportSecurityInfo of the connection.)

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: WIP: Bug 1791633 - deserialize nsITransportSecurityInfo without already having an instance of it r?jschanck

This is an important step in making nsITransportSecurityInfo constant.

Depends on D157994

Comment 3

[Phabricator Automation]

Comment on attachment 9295905 [details]
WIP: Bug 1791633 - don't serialize securityInfo in browser_aboutCertError_exception.js r?Gijs

Revision D157994 was moved to bug 1793841. Setting attachment 9295905 [details] to obsolete.

Comment 4

[Phabricator Automation]

Comment on attachment 9295906 [details]
WIP: Bug 1791633 - deserialize nsITransportSecurityInfo without already having an instance of it r?jschanck

Revision D157995 was moved to bug 1793841. Setting attachment 9295906 [details] to obsolete.

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: Bug 1791633 - rename nsNSSSocketInfo to NSSSocketControl and move to its own file r?jschanck

Comment 6

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: Bug 1791633 - rename nsISSLSocketControl to nsITLSSocketControl and move it and nsITransportSecurityInfo to PSM r?kershaw

Depends on D160310

Comment 7

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: Bug 1791633 - separate nsITLSSocketControl from nsITransportSecurityInfo r?jschanck

Depends on D160311

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f57131b9cfe2
rename nsNSSSocketInfo to NSSSocketControl and move to its own file r=jschanck
https://hg.mozilla.org/integration/autoland/rev/f5a4bfdaba40
rename nsISSLSocketControl to nsITLSSocketControl and move it and nsITransportSecurityInfo to PSM r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/ee9744982673
separate nsITLSSocketControl from nsITransportSecurityInfo r=necko-reviewers,kershaw,jschanck

Comment 9

[Atila Butkovits]

Backed out for causing build bustages at nsHttpConnectionMgr.cpp:

Backout link: https://hg.mozilla.org/integration/autoland/rev/2c9975203a9276b093ccaadc485227386a679fa2

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=ee974498267381418f06efd6ab92c1f2c5f3735d

Failure log: https://treeherder.mozilla.org/logviewer?job_id=396552438&repo=autoland&lineNumber=43147

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab0ea0d68f5c
rename nsNSSSocketInfo to NSSSocketControl and move to its own file r=jschanck
https://hg.mozilla.org/integration/autoland/rev/0bcba3375ec0
rename nsISSLSocketControl to nsITLSSocketControl and move it and nsITransportSecurityInfo to PSM r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/23b864e14db0
separate nsITLSSocketControl from nsITransportSecurityInfo r=necko-reviewers,kershaw,jschanck

Comment 11

[Marian-Vasile Laza]

Backed out 3 changesets (Bug 1791633) for causing bustages on TransportSecurityInfo.cpp.
Backout link
Push with failures <--> Bb
Failure Log

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/303e70d38862
rename nsNSSSocketInfo to NSSSocketControl and move to its own file r=jschanck
https://hg.mozilla.org/integration/autoland/rev/705439f1d269
rename nsISSLSocketControl to nsITLSSocketControl and move it and nsITransportSecurityInfo to PSM r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/b45bd4ea0000
separate nsITLSSocketControl from nsITransportSecurityInfo r=necko-reviewers,kershaw,jschanck

Comment 13

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/303e70d38862
https://hg.mozilla.org/mozilla-central/rev/705439f1d269
https://hg.mozilla.org/mozilla-central/rev/b45bd4ea0000