Closed
Bug 179168
Opened 22 years ago
Closed 22 years ago
Clean up to get TestSocketInput necko tool working
Categories
(Core :: Networking, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: depman1, Assigned: rpotts)
References
()
Details
Attachments
(1 file)
|
1.10 KB,
patch
|
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
located in /mozilla/netwerk/test. To get TestSocketInput working, make changes to TestSocketInput.cpp: 1) use nsnull for 2nd argument to AsyncRead() 2) change QI to support nsIRequestObserver 3) remove socket transport service Shutdown() before XPCOM shutdown (sts->Shutdown), so it doesn't shut down twice.
|
Reporter | |
Updated•22 years ago
|
QA Contact: benc → depstein
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #108947 -
Flags: superreview?(darin)
Attachment #108947 -
Flags: review?(dougt)
|
||
Comment 2•22 years ago
|
||
Comment on attachment 108947 [details] [diff] [review] Fixes to get TestSocketInput running again... r=dougt
Attachment #108947 -
Flags: review?(dougt) → review+
|
||
Comment 3•22 years ago
|
||
Comment on attachment 108947 [details] [diff] [review] Fixes to get TestSocketInput running again... sr=darin
Attachment #108947 -
Flags: superreview?(darin)
Attachment #108947 -
Flags: superreview+
Attachment #108947 -
Flags: review?(dougt)
Attachment #108947 -
Flags: review+
|
|
Assignee | |
Comment 4•22 years ago
|
||
patch checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 5•22 years ago
|
||
verified in Mozilla 1.3b Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030108 build
Status: RESOLVED → VERIFIED
|
||
Updated•22 years ago
|
Attachment #108947 -
Flags: review?(dougt)
You need to log in
before you can comment on or make changes to this bug.
Description
•