1791707 - Firefox View promotes mobile even when a mobile device is connected

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P2)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: image.png

I haven't dug into why this is at all, but see the attached screenshot:

• The "Last active" section says it's from an iPad.
• Below that is a CTA to "Get Firefox for mobile"

I assume the expected behaviour here is that there's no CTA to connect a mobile device when one is connected. This persists across restarts and refreshes, so isn't related to a newly connected device.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Ok, I looked :) firefox view has a check for device.type == "mobile" - but this device (correctly) has "tablet". I would put a patch up but I'm about to leave on PTO before all-hands.

Comment 2

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1791707 - Check for tablets when showing Fx View mobile promo r?sfoster

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f16cd526cef2
Check for tablets when showing Fx View mobile promo r=Gijs

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f16cd526cef2

Comment 5

[:Gijs (he/him)]

Comment on attachment 9295804 [details]
Bug 1791707 - Check for tablets when showing Fx View mobile promo r?sfoster

Beta/Release Uplift Approval Request

• User impact if declined: Confusing messaging for tablet users in a new feature
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. create new firefox account on desktop

2. connect an iPad (not iPhone)
3. check if you still get the mobile promo on Firefox View on desktop

• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Straightforward 1-line change with automated tests
• String changes made/needed: Nope
• Is Android affected?: No

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9295804 [details]
Bug 1791707 - Check for tablets when showing Fx View mobile promo r?sfoster

Approved for 106.0b4, thanks.

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/5f8d224a8c5b

Comment 8

[Simon Basca [:SimonB]]

Marking as verified fix on Firefox 106 beta 4 on macOS 12.6 and Firefox iOS v106.0 (19594).
Tested with

• iPad Pro (15.7) -> when connecting to FxA on desktop and iPad the CTA button is no longer displayed. After disconnecting FxA on iPad and no other iOS device is connected, the CTA buton is displayed again.
• iPhone 12 Pro -> when connecting to FxA on desktop and iPhone the CTA button is no longer displayed. After disconnecting FxA on iPhone and no other iOS device is connected, the CTA buton is displayed again.