Closed Bug 1791861 Opened 4 years ago Closed 4 years ago

Fix hover state text and aria label for Default option in Colorways

Categories

(Firefox :: Messaging System, enhancement, P3)

Desktop
All
enhancement

Tracking

()

VERIFIED FIXED
107 Branch
Tracking Status
firefox107 --- verified

People

(Reporter: emcminn, Assigned: emcminn)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

+++ This bug was initially created as a clone of Bug #1790487 +++

Let's please change the existing hover and aria-label text that includes just the colorway title to title and color description:

Default - > Current %Nightly/Beta/Firefox% colors
Playmaker -> Playmaker (red)
Expressionist -> Expressionist (yellow)
Visionary -> Visionary (green)
Activist -> Activist (blue)
Dreamer -> Dreamer (purple)
Innovator -> Innovator (orange)

I missed the change to Default in the original patch; fixing it here.

Assignee: nobody → emcminn
Priority: -- → P3
Pushed by emcminn@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/41536b72cac0 Update tooltip and aria-label for default colorway option r=fluent-reviewers,flod
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch

I‘ve verified this enhancement using the latest Firefox Nightly 107.0a1 de build (Build ID: 20220928094353) on Windows 10 x64, macOS 12.5.1, and Linux Mint 20.2 x64.

  • The “Current Nightly colors” tooltip text is displayed when hovering the default icon theme on the Colorways screen of the “about:welcome” page.
  • On the Colorways modal of the existing users’ Onboarding, the “[object Object]” tooltip text is displayed when hovering the default theme icon, for which I filed a different issue (Bug 1792695).

Considering these, I’m marking this issue as Verified.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: