179189 - When filing a new bug, the generated bugmail doesn't include Product/Component

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Dave Miller [:justdave]]

Date: Sat, 9 Nov 2002 02:17:25 -0800 (PST)
From: [e-mail]
To: [e-mail]
Subject: [Bug 179174] New: Need to fix use of $| (for buffering)
X-Bugzilla-Reason: CC

http://bugzilla.mozilla.org/show_bug.cgi?id=179174

           Summary: Need to fix use of $| (for buffering)
           Version: 2.17
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: blocker
          Priority: --
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]


The pre-CGI.pm code did $| = 1.
[...]

Comment 1

[Bradley Baetz (:bbaetz)]

DIE, EVIL @::LOG_COLUMNS!!!!

Whats happening is that processmail is using log_columns, but product isn't in
there, only product_id.

Evil hack^W^WFix coming, so -> me

Comment 2

[Bradley Baetz (:bbaetz)]

Attachment: fix

We have to get rid of log_columsn well before custfields....

Anyway, try this.

Comment 3

[Dave Miller [:justdave]]

Comment on attachment 105671 [details] [diff] [review]
fix

r= justdave
a= justdave

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 105671 [details] [diff] [review]
fix

>Index: processmail
>===================================================================
>RCS file: /cvsroot/mozilla/webtools/bugzilla/processmail,v
>retrieving revision 1.91
>diff -u -r1.91 processmail
>--- processmail	17 Oct 2002 04:31:53 -0000	1.91
>+++ processmail	9 Nov 2002 11:23:14 -0000
>@@ -108,6 +108,9 @@
>     foreach my $i (@::log_columns) {
>         $values{$i} = shift(@row);
>     }
>+    $values{product} = get_product_name($values{product_id});
>+    $values{component} = get_component_name($values{product_id},
>+                                            $values{component_id});
>     my ($start, $end) = (@row);
>     # $start and $end are considered safe because users can't touch them
>     trick_taint($start);

I love evil hacks that work, but this one doesn't.  Gotta do:

get_component_name($values{component_id});

Comment 5

[Bradley Baetz (:bbaetz)]

Attachment: v2

Err, yeah, of course.

/me wnats function prototyping

Comment 6

[Bradley Baetz (:bbaetz)]

Fixed.