Closed Bug 1791898 Opened 2 years ago Closed 2 years ago

Rename --fxview-element-* custom properties to match common.css conventions

Categories

(Firefox :: Firefox View, task, P3)

task

Tracking

()

RESOLVED FIXED
107 Branch
Tracking Status
firefox107 --- fixed

People

(Reporter: aminomancer, Assigned: kcochrane)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view])

Attachments

(1 file)

--in-content-button-background-hover: var(--fxview-element-hover-color);
--in-content-button-background-active: var(--fxview-element-active-color);
--in-content-button-text-color-hover: var(--fxview-element-hover-text-color);

Just for consistency, these properties should be flipped around so hover-text-color becomes text-color-hover

Also, since --fxview-element-hover-color and --fxview-element-active-color are used for background-color, not text color, we should rename them like this

--fxview-element-hover-color       ->  --fxview-element-background-hover
--fxview-element-active-color      ->  --fxview-element-background-active
--fxview-element-hover-text-color  ->  --fxview-element-text-color-hover

and then they'll just be the same as the --in-content-* properties but with the prefix swapped with --fxview-element-*

Whiteboard: [fidefe-2022-mr1-firefox-view]
Severity: -- → S3
Priority: -- → P2
Priority: P2 → P3
Assignee: nobody → kcochrane
Status: NEW → ASSIGNED
Pushed by kcochrane@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/492ebd394e1a
Renaming --fxview-element-* css variables to match common.css conventions r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: