179201 - There are five review flag types

Status: RESOLVED WONTFIX

(mozilla.org Graveyard :: Server Operations, task)

Description

[Gervase Markham [:gerv]]

Title says it all. One for Phoenix, and one for everyone else. We should make
Phoenix use the same one as everyone else.

Gerv

Comment 1

[Gervase Markham [:gerv]]

Urk. Since the recent changes, this has got worse. There are now three review
flags; one for Bugzilla, one for Phoenix, and one for almost everyone else.
There is also first-review and second-review flag types for Calendar, which
should be removed and replaced with review because it's multiply requestable. 

The longer we leave this problem, the more confused people will become. :-)

Gerv

Comment 2

[Bradley Baetz (:bbaetz)]

This was done on purpose; bugzilla wants its stuff ccd to
[e-mail], whilst phoenix/mozilla don't.

How will people become confused? They can only see one at a time, so from the
POV of the user, they can't tell the difference.

Comment 3

[Gervase Markham [:gerv]]

OK - but in which case, things are still wrong - we need one for Bugzilla, one
for the products which will eventually CC [e-mail], and one for
everyone else - and we still need to fix the Calendar thing.

Gerv

Comment 4

[Myk Melez [:myk] [@mykmelez]]

No "review" requests will ever cc: [e-mail], since that's the
super-reviewers alias.  If review requests ever did get cc:ed somewhere, that
place would likely be different for Phoenix vs. Mozilla requests given the
separate and different development processes for the two efforts.  In short, it
makes sense for Phoenix to have its own "review" flag.

As for Calendar, changes to its configuration are up to its project manager, so
I've emailed him about it.