Open Bug 1792123 Opened 3 years ago Updated 2 years ago

put ModuleSignatureInfo into minidump

Categories

(Toolkit :: Crash Reporting, enhancement)

Product:
Toolkit
Component:
Crash Reporting
Type:
enhancement

Tracking

()

People

(Reporter: willkg, Unassigned)

Details

The crash reporter client adds a ModuleSignatureInfo annotation. The crash ingestion processor passes this annotation along with all the other annotations as "evil json". The stackwalker uses this annotation value for things.

I think there's some effort going into removing the need for the "evil json". If the annotation data was in the minidump or somewhere else, then we could remove another thing that requires the stackwalker to use evil json.

Can we put ModuleSignatureInfo in the minidump?

ModuleSignatureInfo isn't documented in CrashAnnotations.yaml. If it's not emitted anymore, I can remove it from Socorro.

Looks like it's still emitted:

https://searchfox.org/mozilla-central/source/toolkit/crashreporter/minidump-analyzer/minidump-analyzer.cpp#491

So this bug is probably just about documenting it in CrashAnnotations.yaml.

This is still emitted, and will still be emitted when bug 1743983 lands. However we should definitely revisit this and potentially move the data into the minidump.

You need to log in before you can comment on or make changes to this bug.