Make ctrlTab less vulnerable to future unusual or one-off tab behavior
Categories
(Firefox :: Tabbed Browser, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox107 | --- | fixed |
People
(Reporter: aminomancer, Assigned: aminomancer)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
In bug 1791770, a user reported an issue with add-ons unhiding the Firefox View tab. Because ctrlTab adds tabs to the list when they are unhidden, without checking if they're already in the list, add-ons could cause two previews of Firefox View to be added to the ctrlTab panel. Then, upon closing the tab, only one preview would get removed, leaving a preview that relies on broken references to a discarded browser.
This has been fixed by other means more specific to Firefox View, but because it's likely to only be triggered by specific add-ons, there's a risk that a similar problem may crop up in the future and go undetected by tests and contributors. So, it would be good to add some extra protection to make sure we can't add redundant previews to the ctrlTab panel.
We can just check that the tab isn't already in the list before adding it.
|
||
Updated•2 years ago
|
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
Pushed by shughes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/978c3d89d545 Don't add redundant tabs to ctrlTab panel. r=dao
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Description
•