Closed Bug 1792190 Opened 2 years ago Closed 2 years ago

Perma /service-workers/service-worker/same-site-cookies.https.html | same-origin, nested set location with cross-site middle frame and no service worker when Gecko 107 switches to Late Beta on 2022-10-28

Categories

(Core :: DOM: Service Workers, defect, P2)

defect

Tracking

()

VERIFIED FIXED
107 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox105 --- unaffected
firefox106 --- unaffected
firefox107 + verified

People

(Reporter: nataliaCs, Assigned: smayya)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

* TEST-UNEXPECTED-FAIL | /service-workers/service-worker/same-site-cookies.https.html | same-origin, nested set location with cross-site middle frame and no service worker - assert_not_equals: Unspecified-SameSite cookies are not sent with cross-site requests. got disallowed value "COOKIE_VALUE" 
* TEST-UNEXPECTED-FAIL | /service-workers/service-worker/same-site-cookies.https.html | same-origin, nested set location with cross-site middle frame and fallback service worker - assert_not_equals: Unspecified-SameSite cookies are not sent with cross-site requests. got disallowed value "COOKIE_VALUE"

This seems to be regressed by Bug 1697421.
Sunil / Valentin, can you take a look please?
Thank you.

Flags: needinfo?(valentin.gosu)
Flags: needinfo?(smayya)

This is because same-site=lax is not enabled on late-beta.
We need to set to set the prefs in the test metadata in same-site-cookies.https.html.ini like we do here

Flags: needinfo?(valentin.gosu)
Flags: needinfo?(smayya)

:smayya, since you are the author of the regressor, bug 1697421, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Flags: needinfo?(smayya)

As suggested by valentin, I will set the prefs in the test metadata as fix for this.

Flags: needinfo?(smayya)
Assignee: nobody → smayya

Patch is working on today's simulation

In today's beta-simulation got a conflict when importing patch D158350, caused by the landing of bug 1658869
Fortunately the failure isn't happening anymore

Severity: -- → S3
Priority: -- → P2

(In reply to Sandor Molnar from comment #7)

In today's beta-simulation got a conflict when importing patch D158350, caused by the landing of bug 1658869
Fortunately the failure isn't happening anymore

There are some changes made to service-workers/service-worker/same-site-cookies.https.html in Bug 1658869, which might have indirectly fixed this failure we've been seeing in the beta-sim.

I think we can close this bug as fixed?

Flags: needinfo?(smayya)

Thank you for coordinating this Natalia, I agree to close this Bug as fixed.

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(smayya)
Resolution: --- → FIXED

Hello, this seems to be happening again in today's central-as-beta simulation (see here). Could you take a look please? Will reopen this bug for the time being, but if it is another issue that's causing it, please feel free to close it.

Status: RESOLVED → REOPENED
Flags: needinfo?(smayya)
Resolution: FIXED → ---

Is it possible somehow this: https://hg.mozilla.org/mozilla-central/rev/05690d55cdf399e12c384eb74fd66312414ec4d9 can affect it in any way?

I just queued the fix in lando.
Please let us know if there are still issues with that. Thanks!

Flags: needinfo?(smayya)
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/80a16ffc9f4d
set pref same-site=lax for same-site-cookies.https.html tests. r=necko-reviewers,valentin

Backed out for causing Android failures

Flags: needinfo?(smayya)

The failure was unrelated, potentially the test archive got slightly corrupted. Patch will reland.

Flags: needinfo?(smayya)
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/63d9cf4baca9
set pref same-site=lax for same-site-cookies.https.html tests. r=necko-reviewers,valentin
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch

Fixed verified in friday's late beta-sim.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: