1792225 - [wpt-sync] Sync PR 36052 - CSS highlight painting: use new spelling/grammar unless feature off

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36052 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36052
Details from upstream follow.

Delan Azabani <[e-mail]> wrote:

CSS highlight painting: use new spelling/grammar unless feature off

CL:3899651 makes PaintOneSpellingGrammarDecoration take the old code
path (with DocumentMarkerPainter-based squiggly lines) in a couple
of edge cases, in addition to when CSSSpellingGrammarErrors is off.

This patch makes them take the new code path (with the new CSS-based
decorations) in those edge cases, by passing a “decorations override”
to TextDecorationInfo with a static synthesised AppliedTextDecoration
representing the default spelling or grammar decoration, just like how
ComputedStyle::AppliedTextDecorations has a synthesised decoration for
“simple” underlines. We also add crash tests to WPT and wpt_internal
for the SVG case, since CL:3899651 only did so for the other case.

Some callers also needed to be changed, because the assumption that
the decorations in TextDecorationInfo are the same as the decorations
in ComputedStyle is no longer true, but the changes actually make
things simpler.

Like most of the other overrides (but unlike highlight_override_), the
decorations override for a given TextDecorationInfo instance must not
change, because a lot of ctor logic depends on its value (if any).

Bug: 1358810, 1359175
Change-Id: I2b415dec832496dc3a9157dff30d0f6aa44c515f

Reviewed-on: https://chromium-review.googlesource.com/3916195
WPT-Export-Revision: 2c6b82349f3b397f06ead7146d0b304be901ea00

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=30d74c1e987e46dbe24e304f0e20128bdc8e57d5

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e43be55a1ea
[wpt PR 36052] - CSS highlight painting: use new spelling/grammar unless feature off, a=testonly
https://hg.mozilla.org/integration/autoland/rev/0ea1f54b62be
[wpt PR 36052] - Update wpt metadata, a=testonly

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7e43be55a1ea
https://hg.mozilla.org/mozilla-central/rev/0ea1f54b62be