Closed Bug 1792239 Opened 2 years ago Closed 2 years ago

Re-add the Quit menuitem in AppMenu

Categories

(Thunderbird :: Mail Window Front End, task)

Tracking

(thunderbird_esr102 unaffected, thunderbird106 fixed)

RESOLVED FIXED
107 Branch
Tracking Status
thunderbird_esr102 --- unaffected
thunderbird106 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(2 files)

No description provided.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED

Let's uplift this to the next 106 beta since we're getting some reports from users.

Target Milestone: --- → 107 Branch

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/6ed46d1f45e7
Re-add the Quit menuitem in AppMenu. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Uplift-wise, this can go into 106.0b2, but strings won't be translated. That's the case with a lot of strings in beta though, so not really a blocker. If strings get translated in time for b3 they would get picked up automatically.

Comment on attachment 9296005 [details]
Bug 1792239 - Re-add the Quit menuitem in AppMenu. r=aleca

[Approval Request Comment]
User impact if declined: no Quit menuitem in AppMenu
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low

Attachment #9296005 - Flags: approval-comm-beta?

Comment on attachment 9296005 [details]
Bug 1792239 - Re-add the Quit menuitem in AppMenu. r=aleca

[Triage Comment]
APproved for beta

Attachment #9296005 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9296005 [details]
Bug 1792239 - Re-add the Quit menuitem in AppMenu. r=aleca

Resetting approval for now due to test failures on comm-central.

Attachment #9296005 - Flags: approval-comm-beta+ → approval-comm-beta?

Which test failed because of this patch?

For whatever reason, changing this key caused those test failures: https://hg.mozilla.org/comm-central/rev/6ed46d1f45e7ee65676e02e44e36e290e7f7f250#l1.12

I'll have a patch for it.

Launched a try run and it looks good: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=2658bf81af5e7d8695db7ad381840af69763ea21

For whatever reason, not using the key directly in that key command causes test issues, even tho everything works when using the app.
I'm adding that key back from the OTD file, just to fix things, and I also updated the key to match what Firefox is doing with the internal variation for macos.

Richard, can you check that patch on Windows and macOS?

Reopening due to test failures.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/2f7c4a7cc69b
Fix message menubar autohide broken tests. r=#thunderbird-reviewers,Paenglab

Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED

This is good for beta uplift now.

Flags: needinfo?(rob)

Comment on attachment 9296005 [details]
Bug 1792239 - Re-add the Quit menuitem in AppMenu. r=aleca

[Triage Comment]
Re-approving 2 patches for beta.

Flags: needinfo?(rob)
Attachment #9296005 - Flags: approval-comm-beta? → approval-comm-beta+
Duplicate of this bug: 1787943
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: