Re-add the Quit menuitem in AppMenu
Categories
(Thunderbird :: Mail Window Front End, task)
Tracking
(thunderbird_esr102 unaffected, thunderbird106 fixed)
Tracking | Status | |
---|---|---|
thunderbird_esr102 | --- | unaffected |
thunderbird106 | --- | fixed |
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(2 files)
48 bytes,
text/x-phabricator-request
|
rjl
:
approval-comm-beta+
|
Details | Review |
48 bytes,
text/x-phabricator-request
|
Details | Review |
Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Comment 2•2 years ago
|
||
Let's uplift this to the next 106 beta since we're getting some reports from users.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/6ed46d1f45e7
Re-add the Quit menuitem in AppMenu. r=aleca
Comment 4•2 years ago
|
||
Uplift-wise, this can go into 106.0b2, but strings won't be translated. That's the case with a lot of strings in beta though, so not really a blocker. If strings get translated in time for b3 they would get picked up automatically.
Assignee | ||
Comment 5•2 years ago
|
||
Comment on attachment 9296005 [details]
Bug 1792239 - Re-add the Quit menuitem in AppMenu. r=aleca
[Approval Request Comment]
User impact if declined: no Quit menuitem in AppMenu
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low
Comment 6•2 years ago
|
||
Comment on attachment 9296005 [details]
Bug 1792239 - Re-add the Quit menuitem in AppMenu. r=aleca
[Triage Comment]
APproved for beta
Comment 7•2 years ago
|
||
Comment on attachment 9296005 [details]
Bug 1792239 - Re-add the Quit menuitem in AppMenu. r=aleca
Resetting approval for now due to test failures on comm-central.
Assignee | ||
Comment 8•2 years ago
|
||
Which test failed because of this patch?
Comment 9•2 years ago
|
||
For whatever reason, changing this key caused those test failures: https://hg.mozilla.org/comm-central/rev/6ed46d1f45e7ee65676e02e44e36e290e7f7f250#l1.12
I'll have a patch for it.
Comment 10•2 years ago
|
||
testing the autohide menubar: https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=Oc5fUS6nT2q79uzWVa-JbQ.0
Comment 11•2 years ago
|
||
Comment 12•2 years ago
|
||
Launched a try run and it looks good: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=2658bf81af5e7d8695db7ad381840af69763ea21
For whatever reason, not using the key
directly in that key command causes test issues, even tho everything works when using the app.
I'm adding that key back from the OTD file, just to fix things, and I also updated the key to match what Firefox is doing with the internal variation for macos.
Richard, can you check that patch on Windows and macOS?
Comment 13•2 years ago
|
||
Reopening due to test failures.
Updated•2 years ago
|
Comment 14•2 years ago
|
||
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/2f7c4a7cc69b
Fix message menubar autohide broken tests. r=#thunderbird-reviewers,Paenglab
Comment 16•2 years ago
|
||
Comment on attachment 9296005 [details]
Bug 1792239 - Re-add the Quit menuitem in AppMenu. r=aleca
[Triage Comment]
Re-approving 2 patches for beta.
Comment 17•2 years ago
|
||
bugherder uplift |
Updated•1 year ago
|
Description
•