1792344 - Add targeting in ASRouter for distributions

Status: VERIFIED FIXED

(Firefox :: Messaging System, task)

Description

[Mark Banner (:standard8)]

We need to be able to exclude distributions from studies.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1792344 - Add targeting in ASRouter for distributions. r?Mardak!,mkaply!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd3ab0559b8a
Add targeting in ASRouter for distributions. r=Mardak,mkaply

Comment 3

[Cristian Tuns]

Backed out for causing node failures

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL karma | activity-stream:ASRTargeting docs:All targeting params documented in targeting-attributes.md should have docs and table of contents entry for distributionId: Didn't find a table of contents entry for distributionId: expected [ Array(51) ] to include 'distributionId'

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/964f67aa499c
Add targeting in ASRouter for distributions. r=Mardak,mkaply

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/964f67aa499c

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 9296111 [details]
Bug 1792344 - Add targeting in ASRouter for distributions. r?Mardak!,mkaply!

Beta/Release Uplift Approval Request

• User impact if declined: When running experiments, distributions may be affected when we don't want them to be. This allows excluding distributions from experiments.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: This will be tested as part of experiment QA.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small additional function to allow checking if a distribution is active or not.
• String changes made/needed: None
• Is Android affected?: No

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9296111 [details]
Bug 1792344 - Add targeting in ASRouter for distributions. r?Mardak!,mkaply!

Approved for 106.0b6.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/476a221fef46

Comment 9

[Mark Banner (:standard8)]

Attachment: Bug 1792344 - Add targeting in ASRouter for distributions (release branch)

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 9296523 [details]
Bug 1792344 - Add targeting in ASRouter for distributions (release branch)

Beta/Release Uplift Approval Request

• User impact if declined: When running experiments, distributions may be affected when we don't want them to be. This allows excluding distributions from experiments.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: This will be tested as part of experiment QA.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small additional function to allow checking if a distribution is active or not.
• String changes made/needed: None
• Is Android affected?: No

Comment 11

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using Firefox 106 beta 6 and latest Nightly 107.0a1 under Win 10 64-bit and Mac OSX 10.14.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9296523 [details]
Bug 1792344 - Add targeting in ASRouter for distributions (release branch)

Approved for 105.0.2.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/11ca01523a13

Comment 14

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed in Firefox 105.0.2 on Windows 10, Ubuntu 22 and macOS. The experiment is not applied on distribution builds, that are either region eligible or have the search-config pulled.