1792356 - Non-scriptable interfaces don't need to be marked builtinclass

Status: RESOLVED FIXED

(Core :: XPCOM, task, P3)

Description

[Andrew McCreight [:mccr8]]

Non-scriptable interfaces can't be implemented by JS, so they don't need to be marked builtinclass. I think we can make this an error once the existing instances are cleaned up. (Bug 1792334 is marked as a dependency because XPConnect is a major offender here.)

Comment 1

[Andrew McCreight [:mccr8]]

Interfaces can also be marked [noscript] which doesn't make any sense, so I think that should also be an error.

Comment 2

[Andrew McCreight [:mccr8]]

Well, [noscript] on interfaces is redundant, as all interfaces are not scriptable unless they say they [scriptable].

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1792356, part 1 - [noscript] on XPIDL interfaces doesn't do anything.

The [noscript] attribute does nothing on XPIDL interfaces, so make it
invalid so people don't think something might be affected if they set it.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Bug 1792356, part 2 - Non-scriptable interfaces don't need to be marked [builtinclass].

If an interface isn't scriptable, then it is invisible to script, so it
can't be implemented by it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aae62785df37
part 1 - [noscript] on XPIDL interfaces doesn't do anything. r=xpcom-reviewers,necko-reviewers,nika,kershaw
https://hg.mozilla.org/integration/autoland/rev/b5c47c0780e5
part 2 - Non-scriptable interfaces don't need to be marked [builtinclass]. r=xpcom-reviewers,nika

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/aae62785df37
https://hg.mozilla.org/mozilla-central/rev/b5c47c0780e5