Closed Bug 1792356 Opened 2 months ago Closed 1 month ago

Non-scriptable interfaces don't need to be marked builtinclass

Categories

(Core :: XPCOM, task, P3)

task

Tracking

()

RESOLVED FIXED
107 Branch
Tracking Status
firefox107 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(2 files)

Non-scriptable interfaces can't be implemented by JS, so they don't need to be marked builtinclass. I think we can make this an error once the existing instances are cleaned up. (Bug 1792334 is marked as a dependency because XPConnect is a major offender here.)

Interfaces can also be marked [noscript] which doesn't make any sense, so I think that should also be an error.

Summary: Nonscriptable interfaces don't need to be marked builtinclass → Non-scriptable interfaces don't need to be marked builtinclass

Well, [noscript] on interfaces is redundant, as all interfaces are not scriptable unless they say they [scriptable].

Depends on: 1792357

The [noscript] attribute does nothing on XPIDL interfaces, so make it
invalid so people don't think something might be affected if they set it.

If an interface isn't scriptable, then it is invisible to script, so it
can't be implemented by it.

See Also: → 1792436
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aae62785df37
part 1 - [noscript] on XPIDL interfaces doesn't do anything. r=xpcom-reviewers,necko-reviewers,nika,kershaw
https://hg.mozilla.org/integration/autoland/rev/b5c47c0780e5
part 2 - Non-scriptable interfaces don't need to be marked [builtinclass]. r=xpcom-reviewers,nika
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.