Closed Bug 1792473 Opened 4 months ago Closed 4 months ago

Use modern flexbox in devtools

Categories

(DevTools :: General, defect)

defect

Tracking

(firefox107 fixed)

RESOLVED FIXED
107 Branch
Tracking Status
firefox107 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

Attachments

(1 file)

No description provided.

This shouldn't have any behavior change, other than avoiding XUL / CSS
interaction issues.

I had to tweak a bit a few of the webconsole split styles to preserve
behavior (even though without the styles it ends up working out because
the collapsed console would be out of view anyways).

The reason for the changes are:

  • visibility: collapse doesn't prevent min-height from applying on
    modern flexbox. So just collapse it using height properly. We need to
    use !important, at least on height, to override the style attribute
    set by the splitter.

  • XUL flexbox prefers flexing to honoring min-height. So the
    min-height: 75px on the deck is ineffective (but wouldn't with
    flexbox emulation) so just remove it.

I needed to adjust the test since the fractional part of the container
wasn't getting rounded on my machine, but that's a pre-existing issue
that happens with my DPI settings both before and after the patch.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d79027c38f41
Use modern flex emulation in devtools. r=devtools-reviewers,jdescottes
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77caa64db42e
Use modern flex emulation in devtools. r=devtools-reviewers,jdescottes
Flags: needinfo?(emilio)
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
Regressions: 1793505

== Change summary for alert #35573 (as of Sun, 02 Oct 2022 21:24:28 GMT) ==

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
10% damp browser-toolbox.styleeditor-ready.DAMP macosx1015-64-shippable-qr e10s fission stylo webrender-sw 397.22 -> 436.43
9% damp browser-toolbox.styleeditor-ready.DAMP macosx1015-64-shippable-qr e10s fission stylo webrender 405.80 -> 440.85
8% damp browser-toolbox.styleeditor-ready.DAMP windows10-64-shippable-qr e10s fission stylo webrender 470.44 -> 510.29
7% damp browser-toolbox.styleeditor-ready.DAMP windows10-64-shippable-qr e10s fission stylo webrender-sw 476.65 -> 511.69
7% damp browser-toolbox.styleeditor-ready.DAMP linux1804-64-shippable-qr e10s fission stylo webrender-sw 423.12 -> 452.35
3% damp browser-toolbox.inspector-ready.DAMP windows10-64-shippable-qr e10s fission stylo webrender-sw 438.07 -> 452.59
3% damp browser-toolbox.inspector-ready.DAMP windows10-64-shippable-qr e10s fission stylo webrender 440.32 -> 453.44
3% damp browser-toolbox.inspector-ready.DAMP macosx1015-64-shippable-qr e10s fission stylo webrender 378.45 -> 388.01
2% damp browser-toolbox.inspector-ready.DAMP macosx1015-64-shippable-qr e10s fission stylo webrender-sw 376.84 -> 386.09
2% damp browser-toolbox.inspector-ready.DAMP macosx1015-64-shippable-qr e10s fission stylo webrender-sw 376.50 -> 384.04

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=35573

Various regressions in browser toolbox performance tests

Regressions: 1794393
Regressions: 1796746
Regressions: 1796168
Regressions: 1798140
You need to log in before you can comment on or make changes to this bug.