1792473 - Use modern flexbox in devtools

Status: RESOLVED FIXED

(DevTools :: General, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1792473 - Use modern flex emulation in devtools. r=#devtools-reviewers

This shouldn't have any behavior change, other than avoiding XUL / CSS
interaction issues.

I had to tweak a bit a few of the webconsole split styles to preserve
behavior (even though without the styles it ends up working out because
the collapsed console would be out of view anyways).

The reason for the changes are:

• visibility: collapse doesn't prevent min-height from applying on
  modern flexbox. So just collapse it using height properly. We need to
  use !important, at least on height, to override the style attribute
  set by the splitter.

• XUL flexbox prefers flexing to honoring min-height. So the
  min-height: 75px on the deck is ineffective (but wouldn't with
  flexbox emulation) so just remove it.

I needed to adjust the test since the fractional part of the container
wasn't getting rounded on my machine, but that's a pre-existing issue
that happens with my DPI settings both before and after the patch.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d79027c38f41
Use modern flex emulation in devtools. r=devtools-reviewers,jdescottes

Comment 3

[Atila Butkovits]

Backed out for causing failure at test_focus_general.xhtml.

Backout link: https://hg.mozilla.org/integration/autoland/rev/5121a6f0552027e3206425b54bb624fa92a932e2

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=bAOM1svDRiO1T7Vl8KfGww.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d79027c38f41f1f2035a0366e3465e1022212c84

Failure log: https://treeherder.mozilla.org/logviewer?job_id=391807794&repo=autoland&lineNumber=4439

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77caa64db42e
Use modern flex emulation in devtools. r=devtools-reviewers,jdescottes

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/77caa64db42e

Comment 6

[Julian Descottes [:jdescottes]]

== Change summary for alert #35573 (as of Sun, 02 Oct 2022 21:24:28 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
10%	damp browser-toolbox.styleeditor-ready.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	397.22 -> 436.43
9%	damp browser-toolbox.styleeditor-ready.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	405.80 -> 440.85
8%	damp browser-toolbox.styleeditor-ready.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	470.44 -> 510.29
7%	damp browser-toolbox.styleeditor-ready.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	476.65 -> 511.69
7%	damp browser-toolbox.styleeditor-ready.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	423.12 -> 452.35
3%	damp browser-toolbox.inspector-ready.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	438.07 -> 452.59
3%	damp browser-toolbox.inspector-ready.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	440.32 -> 453.44
3%	damp browser-toolbox.inspector-ready.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	378.45 -> 388.01
2%	damp browser-toolbox.inspector-ready.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	376.84 -> 386.09
2%	damp browser-toolbox.inspector-ready.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	376.50 -> 384.04

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=35573

Comment 7

[Julian Descottes [:jdescottes]]

Various regressions in browser toolbox performance tests